Skip to content

Commit a97a80b

Browse files
authored
Merge pull request #1746 from aehrc/issue/1733
Remove `openOnFocus` prop from autocomplete fields
2 parents 11ac93e + e420716 commit a97a80b

File tree

8 files changed

+74
-53
lines changed

8 files changed

+74
-53
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ For changelogs of other libraries, please refer to their respective repositories
1010

1111
Changelog only includes changes from version 0.36.0 onwards.
1212

13+
## [1.2.6] - 2025-10-28
14+
### Fixed
15+
- Remove `openOnFocus` prop from autocomplete fields to allow screen readers to read out label, placeholder text and control's role. Refer to issue [#1733](https://github.com/aehrc/smart-forms/issues/1733)
16+
1317
## [1.2.5] - 2025-10-28
1418
### Fixed
1519
- Use `deepEqual` for checkbox answer matching instead of JSON.stringify equality to correctly compare valueCoding objects. Refer to issue [#1738](https://github.com/aehrc/smart-forms/issues/1738)

LOCAL_DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ P.S. We had `alpha` as a pre-release branch before the recent v1.0.0 release. Th
545545

546546
## Common issues
547547

548-
NPM workspaces can be a bit inconsistent at times, so it is a good idea to run `npm install` in the directory you are working on to ensure dependencies are installed correctly.
548+
NPM workspaces can be a bit inconsistent at times, so it is a good idea to merge main back to your branch first, then run `npm install` in the directory you are working on to ensure dependencies are installed correctly.
549549
If `npm install` doesn't resolve the issue, try deleting the `node_modules` directory (or `package-lock.json` at times) and running `npm install` again.
550550

551551
Sometimes packages in the monorepo can have different versions of the same dependency, which may cause issues. Ensure that the package/app you are working on have the same dependency versions as the other packages in the monorepo.

apps/smart-forms-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@aehrc/sdc-assemble": "^2.0.2",
2929
"@aehrc/sdc-populate": "^4.6.2",
3030
"@aehrc/sdc-template-extract": "^1.0.14",
31-
"@aehrc/smart-forms-renderer": "^1.2.5",
31+
"@aehrc/smart-forms-renderer": "^1.2.6",
3232
"@dnd-kit/core": "^6.3.1",
3333
"@emotion/react": "^11.14.0",
3434
"@emotion/styled": "^11.14.1",

apps/smart-forms-app/src/features/playground/components/PlaygroundQuestionnairePicker.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ function PlaygroundQuestionnairePicker(props: PlaygroundQuestionnairePickerProps
102102
getOptionLabel={(option) => `${option}`}
103103
value={!selectedQuestionnaireId ? null : selectedQuestionnaireId}
104104
onChange={(_, newValue) => setSelectedQuestionnaireId(newValue ?? '')}
105-
openOnFocus
106105
autoHighlight
107106
size="small"
108107
data-test="questionnaire-picker-playground"

0 commit comments

Comments
 (0)