Skip to content

Commit aad96fd

Browse files
committed
Create driver query for the unit test
1 parent 2c9e1b8 commit aad96fd

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5View.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ predicate isBuiltInControl(string qualifiedTypeUri) {
190190
/**
191191
* A UI5 View that might include XSS sources and sinks in standard controls.
192192
*/
193-
/* TODO: Update docstring */
194193
abstract class UI5View extends File {
195194
abstract string getControllerName();
196195

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5XssQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ private module TrackPlaceAtCallConfigFlow = TaintTracking::Global<TrackPlaceAtCa
9090
* TODO 2: Model the `placeAt`:
9191
*/
9292

93-
private class DangerouslySetElementValueOfInstantiatedHTMLControlPlacedAtDom extends DataFlow::Node {
93+
class DangerouslySetElementValueOfInstantiatedHTMLControlPlacedAtDom extends DataFlow::Node {
9494
HTMLControlInstantiation htmlControlInstantiation;
9595
ControlPlaceAtCall placeAtCall;
9696

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import javascript
2-
import advanced_security.javascript.frameworks.ui5.UI5
3-
import advanced_security.javascript.frameworks.ui5.UI5View
2+
import advanced_security.javascript.frameworks.ui5.UI5XssQuery
43

5-
select "TODO", "TODO"
4+
from DangerouslySetElementValueOfInstantiatedHTMLControlPlacedAtDom htmlContent
5+
select htmlContent, "Content write to an HTML element instantiated and placed in a DOM tree"

0 commit comments

Comments
 (0)