Skip to content

Conversation

@moritzraho
Copy link
Member

@moritzraho moritzraho commented Oct 29, 2025

Description

This is a breaking change

  1. remove default cache control metadata
  2. remove the browser cacheduration config support, see feat!: remove cache durations for custom cache-control headers aio-cli-lib-app-config#42
  3. support custom cache control headers. Set via response-headers:
# app.config.yaml
application:
  web:
    response-headers:
      /*.html:
        cache-control: s-maxage=33; max-age=0
      /*.js:
        cache-control: s-maxage=3333; max-age=0

will directly set the cacheControl S3 property, this is treated differently from a custom metadata/header (not setting an adp-<header> metadata):

index.html => s-maxage=33; max-age=0
index381910.js => s-maxage=3333; max-age=0
index83917.css => NO headers (previously s-maxage=0; max-age=<cacheduration>)

documentation PR: AdobeDocs/app-builder#450

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

}

if (cacheControl) {
uploadParams[awsCacheControlMetadata] = cacheControl
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we lock this to specific values?

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants