-
Notifications
You must be signed in to change notification settings - Fork 5
feat!: remove cache durations for custom cache-control headers #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat!: remove cache durations for custom cache-control headers #42
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I'm wondering since this is a breaking change (thus a major) do we want to remove the two other deprecations in this release as well, maybe something we need to discuss. |
Good idea Edit: after looking into it, some apps may still rely on the old configuration layout. We should (probably) gather some metrics first. Maybe we don't want to add an additional dependency for this release. |
| name: configName | ||
| } | ||
|
|
||
| if (singleUserConfig.htmlCacheDuration || singleUserConfig.jsCacheDuration || singleUserConfig.cssCacheDuration || singleUserConfig.imageCacheDuration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const depValues = ['htmlCacheDuration', 'jsCacheDuration', 'cssCacheDuration', 'imageCacheDuration']
if (Object.keys(singleUserConfig).some(item => depValues.includes(item))) {...}
|
Flagging as do-not-merge while we go through deprecation. #44 make an incremental step toward this. |
Description
BREAKING CHANGE
Remove the following global level configuration entries:
htmlcachedurationjscachedurationcsscachedurationimagecachedurationNote: we don't deprecated it as we want to favor custom cache-control headers under the correct
webconfiguration category. see adobe/aio-lib-web#227 for more detailsThis also fixes warning logs that were sent to debugger.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: