Feature/disqualification -> dev #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix ordered search type lookup in event history * add failure test case for event history ordered lookup
…re-android into feature/disqualification
* Added handling for insert and insertIfNotExists rule consequence * remove keys look up in event history insert/insertIfNotExists consequence * Dispatch event after insert event history consequence * Tests for insert & insertIfNotExists rule consequence * update API dump * fix failing functional test * fix formatting issues * addressing code review comments * change fnv1a32 to produce 0 hash for empty mask map * fix typo in log * Adding additional tests for invalid event history rules * fix test json content
…tion Change ExtensionApi getHistoricalEvents API to be on par with Core iOS
…ure/disqualification
Merging main to feature/disqualification branch
…dobe/aepsdk-core-android-1 into feature/disqualification
…tion Added implementation of mostRecent search type for historical lookup
Update usages and tests accordingly
Update usages and tests accordingly
* Dispatch consequence in an event for schema type if its not eventHistory * Add support for nested lists to map flattening logic * disable list flattening for ~all_url for backward compatibility * Add more tests and rename existing to maintain uniformity * Separate list and array flattening as extension functions * Unit tests for list and array flattening extension functions * Add entire rule consequence in event dispatched as a result of event history insert * Set newest and oldest occurance to null for event not found in event history
spoorthipujariadobe
requested review from
prudrabhat,
timkimadobe and
yangyansong-adbe
* Dispatch consequence in an event for schema type if its not eventHistory * Add support for nested lists to map flattening logic * disable list flattening for ~all_url for backward compatibility * Add more tests and rename existing to maintain uniformity * Separate list and array flattening as extension functions * Unit tests for list and array flattening extension functions * Add entire rule consequence in event dispatched as a result of event history insert * Set newest and oldest occurance to null for event not found in event history * early escape from insert/insertIfNotExists if event hash is 0
prudrabhat
approved these changes
Jul 22, 2025
Contributor
prudrabhat
left a comment
prudrabhat
left a comment
There was a problem hiding this comment.
LGTM. Let's also get a +1 from @yangyansong-adbe before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to support content card disqualification
ExtensionApi.getHistoricalEventsAPI and added a new one which is consistent with the iOS SDK which provides a callback with an array ofEventHistoryResult, one for eachEventHistoryRequestpassed in the API call.insert/insertIfNotExistswhich allows writing to event historyExtensionApi.recordHistoricalEventsAPI to allow extensions to write to event history directly.mostRecenthistorical condition search typeRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: