Skip to content

Move decorateButtons to scripts.js? #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shsteimer opened this issue Feb 21, 2024 · 0 comments
Open

Move decorateButtons to scripts.js? #43

shsteimer opened this issue Feb 21, 2024 · 0 comments

Comments

@shsteimer
Copy link
Contributor

shsteimer commented Feb 21, 2024 •
edited
Loading

I find the implementation of decorateButtons to be rather opinionated and something that frequently needs to be tweaked or modified on a per project basis depending on how buttons are used, how many different button variations there are, etc. A search of project repos, shows that this is not uncommon, https://github.com/search?q=org%3Ahlxsites+path%3A%2F%28%5E%7C%5C%2F%29scripts%5C.js%24%2F+button&type=code

Anyway, just something that I think may warrant some consideration/discussion of the correct place for this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shsteimer