Make CSV conversion scripts more robust

Author: ad-si

Diff for: scripts/csv2yaml/dkb.js

@@ -49,14 +49,16 @@ async function normalizeAndPrint (filePathTemp) {
           ? {
             transfers: [{
               from: "dkb:giro",
-              to: noteToAccount(transaction.from) || noteToAccount(note),
+              to: noteToAccount(transaction.to) ||
+                noteToAccount(transaction.from) || noteToAccount(note),
               amount: amount.slice(1),
               "original-amount": transaction["original-amount"],
             }],
           }
           : {
             transfers: [{
-              from: noteToAccount(transaction.from) || noteToAccount(note),
+              from: noteToAccount(transaction.to) ||
+                noteToAccount(transaction.from) || noteToAccount(note),
               to: "dkb:giro",
               // TODO: Remove when github.com/adius/csvnorm/issues/1 is solved
               amount: transaction.amount === "0,00" ? "0 €" : amount,
@@ -81,9 +83,8 @@ async function normalizeAndPrint (filePathTemp) {
   })
 
   csvnorm.default({
-    encoding: "latin1",
     readableStream: fse.createReadStream(filePathTemp),
-    skipLinesStart: 6,
+    skipLinesStart: 4,
     writableStream: csv2json,
   })
 }

Diff for: scripts/csv2yaml/paypal.js

@@ -27,8 +27,8 @@ async function normalizeAndPrint (filePathTemp) {
       .parse(jsonTemp)
       .map(keysToEnglish)
       .map(transaction => {
-        const currency = transaction.currency
-          .replace("EUR", "€")
+        const currency = transaction?.currency
+          ?.replace("EUR", "€")
           .replace("USD", "$")
           .trim()
 
@@ -40,15 +40,15 @@ async function normalizeAndPrint (filePathTemp) {
                 transaction.time,
                 transaction.timezone,
               ].join(" "))
-              .toISOString()
+              ?.toISOString()
               .replace("T", " ")
               .replace(".000Z", ""),
             note: transaction.subject,
           },
           transaction,
         )
         const account = noteToAccount(transaction.name)
-        const transfer = transaction.gross.startsWith("-")
+        const transfer = transaction.gross?.startsWith("-")
           ? {
             from: "_todo_:paypal:" +
               transaction.currency
@@ -61,7 +61,7 @@ async function normalizeAndPrint (filePathTemp) {
             from: account ? account : "paypal",
             to: "_todo_:paypal:" +
               transaction.currency
-                .toLowerCase()
+                ?.toLowerCase()
                 .trim(),
             amount: transaction.gross + " " + currency,
           }
@@ -75,10 +75,10 @@ async function normalizeAndPrint (filePathTemp) {
           newTransaction.transfers.push({
             from: "_todo_:paypal:" +
               transaction.currency
-                .toLowerCase()
+                ?.toLowerCase()
                 .trim(),
             to: "paypal",
-            amount: transaction.fee.slice(1) + " " + currency,
+            amount: transaction.fee?.slice(1) + " " + currency,
             tags: ["fee"],
           })
         }

Diff for: scripts/helpers.js

@@ -63,6 +63,7 @@ export function keysToEnglish (object) {
         .replace(/^Auswirkung auf Guthaben$/i, "balance_impact")
         .replace(/^Ursprünglicher Betrag$/i, "original-amount")
         .replace(/^Versicherungsbetrag$/i, "insurance_amount")
+        .replace(/^Zahlungsempfänger\*in$/i, "to")
         .replace(/^Zahlungsbetrag in ZW$/i, "amount")
         .replace(/^Artikelbezeichnung$/i, "item_title")
         .replace(/^Zahlungswährung \(ZW\)$/i, "currency")
@@ -96,6 +97,7 @@ export function keysToEnglish (object) {
         .replace(/^Buchungstag$/i, "entry-utc")
         .replace(/^Depotnummer$/i, "depot-id")
         .replace(/^Betrag \(EUR\)$/i, "amount")
+        .replace(/^Betrag \(€\)$/i, "amount")
         .replace(/^Buchungstext$/i, "type")
         .replace(/^Beschreibung$/i, "note")
         .replace(/^Belegdatum$/i, "entry-utc")
@@ -187,6 +189,7 @@ export function noteToAccount (note = "") {
     "google": "google",
     "free software foundation": "free_software_foundation",
     "landr audio": "landr",
+    "landr studio": "landr",
     "mzla technologies": "mzla_technologies",
     "vodafone": "vodafone",
     "mailgun": "mailgun",