feat(actix-files): support multiple fallback directory indexes #3699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature / Refactor
PR Checklist
Overview
This modification allows for the support of multiple index file fallbacks, similar to apache2/nginx.
Eg.
[index.actix.html, index.html, index.txt, ...]The implementation appends the indexes to a vector rather than the default option, and is configured
using the existing
Files::index_filewhich can be called multiple times to append each entry.This design should avoid any breaking changes as the default behavior of just calling it once results in the same functionality before the modification.
This PR supports a personal project of mine attempting to implement an caddy/apache-style reverse-proxy service. Supported by a bunch of services I've written recently.
Thank you :)