Skip to content

[BUG] Underscores in configuration file don't work whereas dashes do #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChesterEcwid opened this issue Mar 31, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@ChesterEcwid
Copy link

Describe the bug
Hi! Docs contain explicit note about underscores in config file
https://github.com/actions/dependency-review-action?tab=readme-ov-file#option-2-using-an-external-configuration-file

For external configuration files, the option names use underscores instead of dashes. Example: fail_on_severity

I use separate configuration file for dependency-review-action. If I use underscores in it, configuration options are not applied, they're just skipped. I tried to change underscores to dashes, after that options are applied.

To Reproduce
Steps to reproduce the behavior:

  1. Use separate config file for workflow action.
  2. Set option names with underscores (for example, allow_licenses).
  3. Try to run workflow.
  4. See in result that licenses listed in allow-licenses options are detected as incompatible.

Expected behavior
I think it's enough to change docs: remove not about underscores and fix example code in this chapter https://github.com/actions/dependency-review-action?tab=readme-ov-file#option-2-using-an-external-configuration-file.

Action version
v4

@ChesterEcwid ChesterEcwid added the bug Something isn't working label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant