Skip to content

Commit 27c2961

Browse files
committed
fix(typescript): ensure that eslint recommended overrides are applied
1 parent b8cc031 commit 27c2961

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

types.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ declare module '@typescript-eslint/eslint-plugin' {
9696
'all': ESLint.Linter.LegacyConfig;
9797
'base': ESLint.Linter.LegacyConfig;
9898
'disable-type-checked': ESLint.Linter.LegacyConfig;
99-
'eslint-recommended': ESLint.Linter.LegacyConfig;
99+
'eslint-recommended': ESLint.Linter.LegacyConfig &
100+
Required<Pick<ESLint.Linter.LegacyConfig, 'overrides'>>;
100101
'recommended': ESLint.Linter.LegacyConfig;
101102
/** @deprecated - please use "recommended-type-checked" instead. */
102103
'recommended-requiring-type-checking': ESLint.Linter.LegacyConfig;

typescript.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,11 @@ const generateConfig = () => {
175175
'prettier': pluginPrettier
176176
},
177177
rules: {
178+
// we have to manually include this in flat config due to @typescript-eslint
179+
// expecting a special helper package to be used to translate their configs
180+
// which we're choosing not to use, at least for now
181+
...pluginTypeScriptESLint.configs['eslint-recommended'].overrides[0]
182+
.rules,
178183
...pluginTypeScriptESLint.configs['recommended-type-checked'].rules,
179184
...pluginTypeScriptESLint.configs['stylistic-type-checked'].rules,
180185
...pluginPrettierRecommended.rules,

0 commit comments

Comments
 (0)