feat: add missing required state for query param with $ref (#1308)

Author: js2me

.changeset/six-aliens-tease.md

@@ -0,0 +1,5 @@
+---
+"swagger-typescript-api": patch
+---
+
+add missing required state for query param with $ref

src/schema-routes/schema-routes.ts

@@ -206,6 +206,7 @@ export class SchemaRoutes {
     lodash.each(parameters, (parameter) => {
       const refTypeInfo =
         this.schemaParserFabric.schemaUtils.getSchemaRefType(parameter);
+
       let routeParam = null;
 
       if (refTypeInfo?.rawTypeData.in && refTypeInfo.rawTypeData) {
@@ -217,6 +218,10 @@ export class SchemaRoutes {
           ...refTypeInfo.rawTypeData,
           ...(refTypeInfo.rawTypeData.schema || {}),
         };
+
+        if (parameter?.required && !routeParam.required) {
+          routeParam.required = parameter.required;
+        }
       } else {
         if (!parameter.in) return;
 

tests/spec/propertyNames/__snapshots__/basic.test.ts.snap

@@ -44,5 +44,11 @@ export type FooBarBazNoAdditionalPropertiesPrimitive = object;
 export interface FooBarBazNested {
   dataCount?: Record<KekEnum, number>;
 }
+
+export type ProductId = string;
+
+export interface GetProductsParams {
+  productId: ProductId;
+}
 "
 `;

tests/spec/propertyNames/basic.test.ts

@@ -24,7 +24,9 @@ describe("basic", async () => {
       output: tmpdir,
       silent: true,
       generateClient: false,
-      generateRouteTypes: true,
+      generateRouteTypes: false,
+      extractRequestBody: true,
+      extractRequestParams: true,
     });
 
     const content = await fs.readFile(path.join(tmpdir, "schema.ts"), {

tests/spec/propertyNames/schema.yml

@@ -5,6 +5,20 @@ info:
 security:
   - registryCookieAuth: []
   - cookieAuth: [ ]
+paths:
+  /api/v1/products:
+    get:
+      operationId: getProducts
+      tags:
+        - Products
+      summary: ASDfdsafdsafdsaf
+      parameters:
+        - in: query
+          required: true
+          $ref: '#/components/parameters/ProductIdQueryParam'
+      responses:
+        '200':
+          description: KO
 components:
   schemas:
     FooBarBazRoot:
@@ -53,3 +67,32 @@ components:
         - dadd
         - xzxzxz
         - axzxe
+    ProductId:
+      type: string
+  parameters:
+    LimitQueryParam:
+      name: limit
+      in: query
+      schema:
+        type: integer
+    OffsetQueryParam:
+      name: offset
+      in: query
+      schema:
+        type: integer
+    ProductIdPathParam:
+      name: productId
+      in: path
+      required: true
+      schema:
+        $ref: '#/components/schemas/ProductId'
+    ProductIdQueryParam:
+      name: productId
+      in: query
+      schema:
+        $ref: '#/components/schemas/ProductId'
+    SearchQueryParam:
+      name: search
+      in: query
+      schema:
+        type: string