Update camel-case mapping + write-request

Author: mbtools

src/zcl_pacote.clas.abap

@@ -118,6 +118,12 @@ CLASS zcl_pacote DEFINITION
       RAISING
         zcx_error.
 
+    CLASS-METHODS write_request
+      IMPORTING
+        !write        TYPE abap_bool
+      RETURNING
+        VALUE(result) TYPE string.
+
 ENDCLASS.
 
 
@@ -246,7 +252,7 @@ CLASS zcl_pacote IMPLEMENTATION.
           attachment-tarball-content_type = ajson->get( '/_attachments/' && attachment-key && '/content_type' ).
           attachment-tarball-data         = ajson->get( '/_attachments/' && attachment-key && '/data' ).
           attachment-tarball-length       = ajson->get_integer( '/_attachments/' && attachment-key && '/length' ).
-          INSERT attachment INTO TABLE packument-__attachments.
+          INSERT attachment INTO TABLE packument-_attachments.
         ENDLOOP.
 
         LOOP AT ajson->members( '/versions' ) INTO version-key.
@@ -255,6 +261,10 @@ CLASS zcl_pacote IMPLEMENTATION.
           INSERT version INTO TABLE packument-versions.
         ENDLOOP.
 
+        " TODO: Do we need this?
+        packument-_id  = ajson->get( '/_id' ).
+        packument-_rev = ajson->get( '/_rev' ).
+
         " TODO: validation of packument
 
         result = sort_packument( packument ).
@@ -316,7 +326,7 @@ CLASS zcl_pacote IMPLEMENTATION.
         ENDLOOP.
 
         ajson->setx( '/_attachments:{ }' ).
-        LOOP AT packument-__attachments INTO DATA(attachment).
+        LOOP AT packument-_attachments INTO DATA(attachment).
           ajson->set(
             iv_path = '_attachments/' && attachment-key && '/content_type'
             iv_val  = attachment-tarball-content_type ).
@@ -449,12 +459,21 @@ CLASS zcl_pacote IMPLEMENTATION.
     SORT result-maintainers BY name.
     SORT result-users BY name.
     SORT result-versions BY key.
-    SORT result-__attachments BY key.
+    SORT result-_attachments BY key.
     SORT result-keywords.
 
   ENDMETHOD.
 
 
+  METHOD write_request.
+
+    IF write = abap_true.
+      result = '?write=true'.
+    ENDIF.
+
+  ENDMETHOD.
+
+
   METHOD zif_pacote~delete.
 
     db_persist->delete( pacote-key ).
@@ -508,7 +527,7 @@ CLASS zcl_pacote IMPLEMENTATION.
   METHOD zif_pacote~manifest.
 
     result = request(
-      url         = |{ registry }/{ pacote-name }/{ version }|
+      url         = |{ registry }/{ pacote-name }/{ version }{ write_request( write ) }|
       abbreviated = abbreviated )->cdata( ).
 
     check_result( result ).
@@ -518,7 +537,7 @@ CLASS zcl_pacote IMPLEMENTATION.
 
   METHOD zif_pacote~packument.
 
-    result = request( |{ registry }/{ pacote-name }| )->cdata( ).
+    result = request( |{ registry }/{ pacote-name }{ write_request( write ) }| )->cdata( ).
 
     check_result( result ).
     zif_pacote~set_json( result ).
@@ -557,8 +576,13 @@ CLASS zcl_pacote IMPLEMENTATION.
 
   METHOD zif_pacote~tarball.
 
-    " TODO: Error check (HTTP status)
-    result = request( filename )->data( ).
+    DATA(response) = request( filename ).
+
+    IF response->is_ok( ) = abap_false.
+      check_result( response->cdata( ) ).
+    ELSE.
+      result = response->data( ).
+    ENDIF.
 
   ENDMETHOD.
 ENDCLASS.

src/zif_pacote.intf.abap

@@ -72,12 +72,15 @@ INTERFACE zif_pacote PUBLIC.
     IMPORTING
       version       TYPE string
       abbreviated   TYPE abap_bool DEFAULT abap_false
+      write         TYPE abap_bool DEFAULT abap_false
     RETURNING
       VALUE(result) TYPE string
     RAISING
       zcx_error.
 
   METHODS packument
+    IMPORTING
+      write         TYPE abap_bool DEFAULT abap_false
     RETURNING
       VALUE(result) TYPE string
     RAISING