Skip to content

Enable full screen option on videos under documentation #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aslamdoctor opened this issue Jun 5, 2025 · 3 comments
Closed

Enable full screen option on videos under documentation #2237

aslamdoctor opened this issue Jun 5, 2025 · 3 comments

Comments

@aslamdoctor
Copy link
Contributor

E.g. https://wordpress.github.io/wordpress-playground/quick-start-guide

The full screen option is always disabled.

Image
@madhavraj2004
Copy link
Contributor

i have made a pull request regarding it...

@adamziel
Copy link
Collaborator

I've just merged #2244 and I'm going to close this issue. LMK if anything is off and I'm happy to reopen.

@github-project-automation github-project-automation bot moved this from Inbox to Done in Playground Board Jun 10, 2025
@aslamdoctor
Copy link
Contributor Author

@adamziel Is the page also published? I am not seeing the full screen button enabled.

bgrgicak pushed a commit that referenced this issue Jun 12, 2025
## Motivation for the change, related issues

related #2244 #2237

allowfullscreen was added in this PR, but the allowfullscreen button is
not enabled in the documentation.
https://wordpress.github.io/wordpress-playground/quick-start-guide/

Docusaurus markdown requires the use of JSX notation, so we will change
it to camelCase so that allowfullscreen works properly.

We will make the same change to the Japanese version


https://github.com/user-attachments/assets/8493f6e7-4fcd-49ae-82d5-cde69577f474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants