Skip to content

Fix hasClass on SVG #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix hasClass on SVG #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58b811e
Fix: SVG on some Webkit versions (notably: iOS) don't have attribute …
giorgian May 27, 2013
e79beee
Test that DOM className helpers work correctly with SVGs.
Jun 5, 2013
904b17f
Fix SVG creation in tests.
giorgian Jun 6, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ goog.scope(function() {
* @return {boolean} True if the element has that class.
*/
dom.hasClass = function(el, className) {
return el.classList.contains(className);
return el.classList && el.classList.contains(className);
};

/**
Expand Down
17 changes: 17 additions & 0 deletions test/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,23 @@ $(function() {
ok(!treesaver.dom.hasClass(div, 'test'), 'hasClass: Removed class');
});

test('className helpers on SVG', function () {
var svg = document.createElementNS('http://www.w3.org/2000/svg', 'svg');

equals(treesaver.dom.classes(svg).length, 0, 'classes: Unset className');

treesaver.dom.addClass(svg, 'test');

equals(treesaver.dom.classes(svg).length, 1, 'classes: Single class');
ok(treesaver.dom.hasClass(svg, 'test'), 'hasClass: Single class');
ok(!treesaver.dom.hasClass(svg, 'bogus'), 'hasClass: Single class failure');

treesaver.dom.removeClass(svg, 'test');

equals(treesaver.dom.classes(svg).length, 0, 'classes: Removed class');
ok(!treesaver.dom.hasClass(svg, 'test'), 'hasClass: Removed class');
});

test('hasAttr', function () {
var div = document.createElement('div'),
attr = document.createAttribute('width');
Expand Down