Skip to content

Commit e00d126

Browse files
teo-tsirpanisteo-tsirpanis
authored
Update Core to 2.29. (#582)
* Regenerate bindings for 2.29. * Add new APIs. * Remove UB. * Update tests. * Update Core to 2.29.0. * Run nightlies on `release-2.29`. * Update version to 5.19.0. * Update compatibility suppression file. * Add back ls_recursive V1 implementation, and obsolete the public API. * Update to Core 2.29.1.
1 parent 734a855 commit e00d126

File tree

14 files changed

+486
-35
lines changed

14 files changed

+486
-35
lines changed

‎.github/workflows/nightly.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
platform: macos-arm64
2727
- os: windows-latest
2828
platform: windows-x86_64
29-
tag: [release-2.28, main]
29+
tag: [release-2.29, main]
3030
runs-on: ${{ matrix.os }}
3131
steps:
3232
- name: Checkout TileDB
@@ -73,7 +73,7 @@ jobs:
7373
strategy:
7474
fail-fast: false
7575
matrix:
76-
tag: [release-2.28, main]
76+
tag: [release-2.29, main]
7777
runs-on: ubuntu-latest
7878
steps:
7979
- name: Checkout TileDB-CSharp
@@ -107,7 +107,7 @@ jobs:
107107
fail-fast: false
108108
matrix:
109109
os: [ubuntu-latest, macos-latest, windows-latest]
110-
tag: [release-2.28, main]
110+
tag: [release-2.29, main]
111111
runs-on: ${{ matrix.os }}
112112
steps:
113113
- name: Checkout TileDB-CSharp

‎Directory.Packages.props‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<PropertyGroup>
33
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
44
<TileDBNativePackageName>TileDB.Native</TileDBNativePackageName>
5-
<TileDBNativePackageVersion>[2.28.1,2.29.0)</TileDBNativePackageVersion>
5+
<TileDBNativePackageVersion>[2.29.1,2.30.0)</TileDBNativePackageVersion>
66

77
<!-- The DevelopmentBuild property switches to the locally built native packages.
88
They have a different name to avoid publishing them by mistake, and to

‎docs/obsoletions.md‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Following [the deprecation policy of TileDB Embedded][core-deprecation], obsolet
1111
|[`TILEDB0014`](#TILEDB0014) …[`TILEDB0014`](#TILEDB0014)|5.8.0|5.10.0|
1212
|[`TILEDB0015`](#TILEDB0015) …[`TILEDB0015`](#TILEDB0015)|5.13.0|5.15.0|
1313
|[`TILEDB0016`](#TILEDB0016) …[`TILEDB0016`](#TILEDB0016)|5.17.0|5.19.0|
14+
|[`TILEDB0017`](#TILEDB0017) …[`TILEDB0017`](#TILEDB0017)|5.19.0|5.21.0|
1415

1516
## `TILEDB0001` - Enum value names that start with `TILEDB_` were replaced with C#-friendly names.
1617

@@ -378,4 +379,22 @@ The TileDB filestore APIs, exposed by the `TileDB.CSharp.File` class are obsolet
378379

379380
There is no direct replacement. You can manually store files in TileDB by representing them as one-dimensional dense arrays of bytes.
380381

382+
## `TILEDB0017` - `VFS.VisitChildrenRecursive` original overload is obsolete.
383+
384+
<a name="TILEDB0017"></a>
385+
386+
The `VFS.VisitChildrenRecursive` method behaves inconsistently depending on the storage backend being used. When calling it with an object storage path (S3, Azure, GCS), only files were returned, but on a local file system path, both files and directories were returned.
387+
388+
This was fixed in version 5.19.0. A new overload of `VisitChildrenRecursive` was introduced, which lists directories even in object storage, and its callback delegate includes a boolean parameter to distinguish between files and directories.
389+
390+
For compatibility, the old overload's behavior was preserved, and it was deprecated and will be removed in a future version.
391+
392+
### Version introduced
393+
394+
5.19.0
395+
396+
### Recommended action
397+
398+
Use the overload with the callback that accepts a boolean.
399+
381400
[core-deprecation]: https://github.com/TileDB-Inc/TileDB/blob/dev/doc/policy/api_changes.md

‎sources/TileDB.CSharp/CompatibilitySuppressions.xml‎

Lines changed: 299 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,304 @@
22
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
33
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
44
<Suppression>
5-
<DiagnosticId>PKV006</DiagnosticId>
6-
<Target>net5.0</Target>
5+
<DiagnosticId>CP0001</DiagnosticId>
6+
<Target>T:TileDB.CSharp.ConfigIterator</Target>
7+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
8+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
9+
<IsBaselineSuppression>true</IsBaselineSuppression>
10+
</Suppression>
11+
<Suppression>
12+
<DiagnosticId>CP0001</DiagnosticId>
13+
<Target>T:TileDB.Interop.__sFILE</Target>
14+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
15+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
16+
<IsBaselineSuppression>true</IsBaselineSuppression>
17+
</Suppression>
18+
<Suppression>
19+
<DiagnosticId>CP0001</DiagnosticId>
20+
<Target>T:TileDB.Interop.ArrayHandle</Target>
21+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
22+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
23+
<IsBaselineSuppression>true</IsBaselineSuppression>
24+
</Suppression>
25+
<Suppression>
26+
<DiagnosticId>CP0001</DiagnosticId>
27+
<Target>T:TileDB.Interop.ArraySchemaEvolutionHandle</Target>
28+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
29+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
30+
<IsBaselineSuppression>true</IsBaselineSuppression>
31+
</Suppression>
32+
<Suppression>
33+
<DiagnosticId>CP0001</DiagnosticId>
34+
<Target>T:TileDB.Interop.ArraySchemaHandle</Target>
35+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
36+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
37+
<IsBaselineSuppression>true</IsBaselineSuppression>
38+
</Suppression>
39+
<Suppression>
40+
<DiagnosticId>CP0001</DiagnosticId>
41+
<Target>T:TileDB.Interop.AttributeHandle</Target>
42+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
43+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
44+
<IsBaselineSuppression>true</IsBaselineSuppression>
45+
</Suppression>
46+
<Suppression>
47+
<DiagnosticId>CP0001</DiagnosticId>
48+
<Target>T:TileDB.Interop.ConfigHandle</Target>
49+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
50+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
51+
<IsBaselineSuppression>true</IsBaselineSuppression>
52+
</Suppression>
53+
<Suppression>
54+
<DiagnosticId>CP0001</DiagnosticId>
55+
<Target>T:TileDB.Interop.ConfigIteratorHandle</Target>
56+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
57+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
58+
<IsBaselineSuppression>true</IsBaselineSuppression>
59+
</Suppression>
60+
<Suppression>
61+
<DiagnosticId>CP0001</DiagnosticId>
62+
<Target>T:TileDB.Interop.ContextHandle</Target>
63+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
64+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
65+
<IsBaselineSuppression>true</IsBaselineSuppression>
66+
</Suppression>
67+
<Suppression>
68+
<DiagnosticId>CP0001</DiagnosticId>
69+
<Target>T:TileDB.Interop.DimensionHandle</Target>
70+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
71+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
72+
<IsBaselineSuppression>true</IsBaselineSuppression>
73+
</Suppression>
74+
<Suppression>
75+
<DiagnosticId>CP0001</DiagnosticId>
76+
<Target>T:TileDB.Interop.DomainHandle</Target>
77+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
78+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
79+
<IsBaselineSuppression>true</IsBaselineSuppression>
80+
</Suppression>
81+
<Suppression>
82+
<DiagnosticId>CP0001</DiagnosticId>
83+
<Target>T:TileDB.Interop.FilterHandle</Target>
84+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
85+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
86+
<IsBaselineSuppression>true</IsBaselineSuppression>
87+
</Suppression>
88+
<Suppression>
89+
<DiagnosticId>CP0001</DiagnosticId>
90+
<Target>T:TileDB.Interop.FilterListHandle</Target>
91+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
92+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
93+
<IsBaselineSuppression>true</IsBaselineSuppression>
94+
</Suppression>
95+
<Suppression>
96+
<DiagnosticId>CP0001</DiagnosticId>
97+
<Target>T:TileDB.Interop.GroupHandle</Target>
98+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
99+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
100+
<IsBaselineSuppression>true</IsBaselineSuppression>
101+
</Suppression>
102+
<Suppression>
103+
<DiagnosticId>CP0001</DiagnosticId>
104+
<Target>T:TileDB.Interop.LibC</Target>
105+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
106+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
107+
<IsBaselineSuppression>true</IsBaselineSuppression>
108+
</Suppression>
109+
<Suppression>
110+
<DiagnosticId>CP0001</DiagnosticId>
111+
<Target>T:TileDB.Interop.MarshaledString</Target>
112+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
113+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
114+
<IsBaselineSuppression>true</IsBaselineSuppression>
115+
</Suppression>
116+
<Suppression>
117+
<DiagnosticId>CP0001</DiagnosticId>
118+
<Target>T:TileDB.Interop.MarshaledStringOut</Target>
119+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
120+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
121+
<IsBaselineSuppression>true</IsBaselineSuppression>
122+
</Suppression>
123+
<Suppression>
124+
<DiagnosticId>CP0001</DiagnosticId>
125+
<Target>T:TileDB.Interop.QueryConditionHandle</Target>
126+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
127+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
128+
<IsBaselineSuppression>true</IsBaselineSuppression>
129+
</Suppression>
130+
<Suppression>
131+
<DiagnosticId>CP0001</DiagnosticId>
132+
<Target>T:TileDB.Interop.QueryHandle</Target>
133+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
134+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
135+
<IsBaselineSuppression>true</IsBaselineSuppression>
136+
</Suppression>
137+
<Suppression>
138+
<DiagnosticId>CP0001</DiagnosticId>
139+
<Target>T:TileDB.Interop.SpanExtensions</Target>
140+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
141+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
142+
<IsBaselineSuppression>true</IsBaselineSuppression>
143+
</Suppression>
144+
<Suppression>
145+
<DiagnosticId>CP0001</DiagnosticId>
146+
<Target>T:TileDB.Interop.tiledb_array_schema_evolution_t</Target>
147+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
148+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
149+
<IsBaselineSuppression>true</IsBaselineSuppression>
150+
</Suppression>
151+
<Suppression>
152+
<DiagnosticId>CP0001</DiagnosticId>
153+
<Target>T:TileDB.Interop.tiledb_array_schema_t</Target>
154+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
155+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
156+
<IsBaselineSuppression>true</IsBaselineSuppression>
157+
</Suppression>
158+
<Suppression>
159+
<DiagnosticId>CP0001</DiagnosticId>
160+
<Target>T:TileDB.Interop.tiledb_array_t</Target>
161+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
162+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
163+
<IsBaselineSuppression>true</IsBaselineSuppression>
164+
</Suppression>
165+
<Suppression>
166+
<DiagnosticId>CP0001</DiagnosticId>
167+
<Target>T:TileDB.Interop.tiledb_array_type_t</Target>
168+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
169+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
170+
<IsBaselineSuppression>true</IsBaselineSuppression>
171+
</Suppression>
172+
<Suppression>
173+
<DiagnosticId>CP0001</DiagnosticId>
174+
<Target>T:TileDB.Interop.tiledb_attribute_t</Target>
175+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
176+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
177+
<IsBaselineSuppression>true</IsBaselineSuppression>
178+
</Suppression>
179+
<Suppression>
180+
<DiagnosticId>CP0001</DiagnosticId>
181+
<Target>T:TileDB.Interop.tiledb_config_iter_t</Target>
182+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
183+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
184+
<IsBaselineSuppression>true</IsBaselineSuppression>
185+
</Suppression>
186+
<Suppression>
187+
<DiagnosticId>CP0001</DiagnosticId>
188+
<Target>T:TileDB.Interop.tiledb_config_t</Target>
189+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
190+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
191+
<IsBaselineSuppression>true</IsBaselineSuppression>
192+
</Suppression>
193+
<Suppression>
194+
<DiagnosticId>CP0001</DiagnosticId>
195+
<Target>T:TileDB.Interop.tiledb_ctx_t</Target>
196+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
197+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
198+
<IsBaselineSuppression>true</IsBaselineSuppression>
199+
</Suppression>
200+
<Suppression>
201+
<DiagnosticId>CP0001</DiagnosticId>
202+
<Target>T:TileDB.Interop.tiledb_datatype_t</Target>
203+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
204+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
205+
<IsBaselineSuppression>true</IsBaselineSuppression>
206+
</Suppression>
207+
<Suppression>
208+
<DiagnosticId>CP0001</DiagnosticId>
209+
<Target>T:TileDB.Interop.tiledb_dimension_t</Target>
210+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
211+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
212+
<IsBaselineSuppression>true</IsBaselineSuppression>
213+
</Suppression>
214+
<Suppression>
215+
<DiagnosticId>CP0001</DiagnosticId>
216+
<Target>T:TileDB.Interop.tiledb_domain_t</Target>
217+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
218+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
219+
<IsBaselineSuppression>true</IsBaselineSuppression>
220+
</Suppression>
221+
<Suppression>
222+
<DiagnosticId>CP0001</DiagnosticId>
223+
<Target>T:TileDB.Interop.tiledb_filter_list_t</Target>
224+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
225+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
226+
<IsBaselineSuppression>true</IsBaselineSuppression>
227+
</Suppression>
228+
<Suppression>
229+
<DiagnosticId>CP0001</DiagnosticId>
230+
<Target>T:TileDB.Interop.tiledb_filter_t</Target>
231+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
232+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
233+
<IsBaselineSuppression>true</IsBaselineSuppression>
234+
</Suppression>
235+
<Suppression>
236+
<DiagnosticId>CP0001</DiagnosticId>
237+
<Target>T:TileDB.Interop.tiledb_filter_type_t</Target>
238+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
239+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
240+
<IsBaselineSuppression>true</IsBaselineSuppression>
241+
</Suppression>
242+
<Suppression>
243+
<DiagnosticId>CP0001</DiagnosticId>
244+
<Target>T:TileDB.Interop.tiledb_group_t</Target>
245+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
246+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
247+
<IsBaselineSuppression>true</IsBaselineSuppression>
248+
</Suppression>
249+
<Suppression>
250+
<DiagnosticId>CP0001</DiagnosticId>
251+
<Target>T:TileDB.Interop.tiledb_query_condition_t</Target>
252+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
253+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
254+
<IsBaselineSuppression>true</IsBaselineSuppression>
255+
</Suppression>
256+
<Suppression>
257+
<DiagnosticId>CP0001</DiagnosticId>
258+
<Target>T:TileDB.Interop.tiledb_query_t</Target>
259+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
260+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
261+
<IsBaselineSuppression>true</IsBaselineSuppression>
262+
</Suppression>
263+
<Suppression>
264+
<DiagnosticId>CP0001</DiagnosticId>
265+
<Target>T:TileDB.Interop.tiledb_query_type_t</Target>
266+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
267+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
268+
<IsBaselineSuppression>true</IsBaselineSuppression>
269+
</Suppression>
270+
<Suppression>
271+
<DiagnosticId>CP0001</DiagnosticId>
272+
<Target>T:TileDB.Interop.tiledb_vfs_t</Target>
273+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
274+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
275+
<IsBaselineSuppression>true</IsBaselineSuppression>
276+
</Suppression>
277+
<Suppression>
278+
<DiagnosticId>CP0001</DiagnosticId>
279+
<Target>T:TileDB.Interop.VFSHandle</Target>
280+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
281+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
282+
<IsBaselineSuppression>true</IsBaselineSuppression>
283+
</Suppression>
284+
<Suppression>
285+
<DiagnosticId>CP0002</DiagnosticId>
286+
<Target>M:TileDB.CSharp.Config.Iterate(System.String)</Target>
287+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
288+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
289+
<IsBaselineSuppression>true</IsBaselineSuppression>
290+
</Suppression>
291+
<Suppression>
292+
<DiagnosticId>CP0002</DiagnosticId>
293+
<Target>M:TileDB.CSharp.EnumUtil.DataTypeToType(TileDB.CSharp.DataType)</Target>
294+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
295+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
296+
<IsBaselineSuppression>true</IsBaselineSuppression>
297+
</Suppression>
298+
<Suppression>
299+
<DiagnosticId>CP0002</DiagnosticId>
300+
<Target>M:TileDB.CSharp.EnumUtil.TypeToDataType(System.Type)</Target>
301+
<Left>lib/net8.0/TileDB.CSharp.dll</Left>
302+
<Right>lib/net8.0/TileDB.CSharp.dll</Right>
303+
<IsBaselineSuppression>true</IsBaselineSuppression>
7304
</Suppression>
8305
</Suppressions>

0 commit comments

Comments
 (0)