Skip to content

Reading mail - menu control #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajbrickhouse opened this issue Sep 9, 2024 · 1 comment
Open

Reading mail - menu control #87

ajbrickhouse opened this issue Sep 9, 2024 · 1 comment

Comments

@ajbrickhouse
Copy link

ajbrickhouse commented Sep 9, 2024

If a non-integer value is entered after accessing the read menu, an error will be returned.

2024-09-09 18:15:17 - INFO - Received message from user 'Jay' to BBS1: B
2024-09-09 18:15:17 - INFO - REPLY SEND ID=2514651132
2024-09-09 18:15:22 - INFO - Received message from user 'Jay' to BBS1: M
2024-09-09 18:15:22 - INFO - REPLY SEND ID=2514651133
2024-09-09 18:15:31 - INFO - Received message from user 'Jay' to BBS1: R
2024-09-09 18:15:31 - INFO - REPLY SEND ID=2514651134
2024-09-09 18:15:33 - INFO - REPLY SEND ID=2514651135
2024-09-09 18:15:38 - INFO - Received message from user 'Jay' to BBS1: S
2024-09-09 18:15:38 - ERROR - Unexpected error in deferred execution <class 'ValueError'>
Traceback (most recent call last):
File "/home/tbrinkhuis/TC2-BBS-mesh/venv/lib/python3.10/site-packages/meshtastic/util.py", line 288, in _run
o()
File "/home/tbrinkhuis/TC2-BBS-mesh/venv/lib/python3.10/site-packages/meshtastic/mesh_interface.py", line 1285, in
lambda: pub.sendMessage(topic, packet=asDict, interface=self)
File "/home/tbrinkhuis/TC2-BBS-mesh/venv/lib/python3.10/site-packages/pubsub/core/publisher.py", line 216, in sendMessage
topicObj.publish(**msgData)
File "/home/tbrinkhuis/TC2-BBS-mesh/venv/lib/python3.10/site-packages/pubsub/core/topicobj.py", line 452, in publish
self.__sendMessage(msgData, topicObj, msgDataSubset)
File "/home/tbrinkhuis/TC2-BBS-mesh/venv/lib/python3.10/site-packages/pubsub/core/topicobj.py", line 482, in __sendMessage
listener(data, self, allData)
File "/home/tbrinkhuis/TC2-BBS-mesh/venv/lib/python3.10/site-packages/pubsub/core/listener.py", line 237, in call
cb(**kwargs)
File "/home/tbrinkhuis/TC2-BBS-mesh/server.py", line 71, in receive_packet
on_receive(packet, interface)
File "/home/tbrinkhuis/TC2-BBS-mesh/message_processing.py", line 201, in on_receive
process_message(sender_id, message_string, interface, is_sync_message=False)
File "/home/tbrinkhuis/TC2-BBS-mesh/message_processing.py", line 140, in process_message
handle_mail_steps(sender_id, message, step, state, interface, bbs_nodes)
File "/home/tbrinkhuis/TC2-BBS-mesh/command_handlers.py", line 255, in handle_mail_steps
mail_id = int(message)
ValueError: invalid literal for int() with base 10: 's'

@AdvJosh
Copy link
Contributor

AdvJosh commented Mar 5, 2025

Hey @ajbrickhouse,

I created a pull request with improved error handling in the read bulletin and read mail menus that should resolve this.

#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants