Skip to content

README in each folder #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KrisThielemans opened this issue May 23, 2021 · 9 comments
Closed

README in each folder #90

KrisThielemans opened this issue May 23, 2021 · 9 comments
Milestone

Comments

@KrisThielemans
Copy link
Member

KrisThielemans commented May 23, 2021

I think it'd be nice to have a README.md in each folder, especially if jupyter display the README nicely. @ashgillman I saw it doing that for you. A plugin?

@KrisThielemans KrisThielemans added this to the v3.1 milestone May 23, 2021
@ashgillman
Copy link
Member

No, I was sharing from GitHub last meeting - which renders the README per directory. I did a quick google, but can't see how to do this.

@ashgillman
Copy link
Member

Only the MR and Reg notebooks subdirectories don't currently have READMEs.

@KrisThielemans
Copy link
Member Author

I had seen this as an abandoned PR jupyter/notebook#5299. They recommend using https://github.com/NII-cloud-operation/Jupyter-LC_index.

JupyterLab does this though. Maybe time to switch?

@ashgillman
Copy link
Member

ashgillman commented May 25, 2021

Reading through the thread you posted, it sounds like support for Jupyter Notebooks might be fading. So it could be better to be ahead of the curve with JupyterLab. It also seems to have more features for other data formats.

JupyterLab pros:

  • README
  • If we could show the terminal/kernel output side-by-side would be very nice for STIR, since a lot of the output is hidden (not sure if this is possible though)
  • Continued support and coming features.

cons:

  • People, if they're familiar with anything, are more likely to be familiar with Notebooks
  • Not sure if its going to be more confusing?
  • More changes/testing

@KrisThielemans
Copy link
Member Author

Turns out that @casperdcl already install jupyterlab on the docker image (of course). So, as opposed to going to
http://localhost:9999/, you just go to http://localhost:9999/lab. On the VM I had to do python3 -m pip install jupyterlab; and start with jupyter lab.

If you click on a README.md, it opens it up in an editor as before, but right-clicking allows you to show it formatted. Not very smooth yet, but at least something.

However

A bit too early days for me therefore.

@ashgillman
Copy link
Member

I was hoping it would automatically preview when navigating to the folder. This still requires users to open the file - a low bar I know but one not all will navigate

@KrisThielemans
Copy link
Member Author

yeah, doesn't help a ton.

there was a notebook extension mentioned that does the trick, but I guess it's a bit lower priority at the moment! Let's just get the READMEs in (and some other tiny bits...)

@KrisThielemans
Copy link
Member Author

@johannesmayer @ckolbPTB can you please create a MR/README.md? Use links for the notebooks.

KrisThielemans added a commit that referenced this issue Jun 24, 2021
partially addresses #90
@KrisThielemans
Copy link
Member Author

all done with #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants