test(rightassetcustodian): setMaxAllowed

Author: geolffreym

contracts/access/AccessManager.sol

@@ -37,12 +37,12 @@ contract AccessManager is Initializable, UUPSUpgradeable, AccessManagerUpgradeab
         // - GOV_ROLE: Represents decentralized community governance.
         // Decisions are made through collective voting mechanisms (e.g., token-weighted, quadratic).
         //
-        // Group/Sub-DAO Based Roles:
-        // - ADMIN_ROLE: Managed by a smart account or sub-DAO.
+        // Group/Council Based Roles:
+        // - ADMIN_ROLE: Managed by a smart account or council.
         // Handles protocol upgrades, pause mechanisms, and operational role assignments.
-        // - MOD_ROLE: Managed by a smart account or sub-DAO.
+        // - MOD_ROLE: Managed by a smart account or council.
         // Approves policy submissions and moderates hook operations.
-        // - REF_ROLE: Managed by a smart account or sub-DAO.
+        // - REF_ROLE: Managed by a smart account or council.
         // Participates in governance referenda for content curation and distributor selection.
         //
         // Individual/Contract Based Roles:
@@ -52,15 +52,15 @@ contract AccessManager is Initializable, UUPSUpgradeable, AccessManagerUpgradeab
         // content uploads without conventional verification.
 
         /*
-            GOV_ROLE (Community Governance)
+            GOV_ROLE (Community Governance) 
             │
-            ├── ADMIN_ROLE (Smart Account / Sub-DAO)
+            ├── ADMIN_ROLE (Smart Account / Council) 
             │   │
-            │   ├── MOD_ROLE (Smart Account / Sub-DAO)
+            │   ├── MOD_ROLE (Smart Account / Council) 
             │   │
-            │   └── OPS_ROLE (Internal Contract Role)
+            │   └── OPS_ROLE (Internal Contract Role)  
             │
-            ├── REF_ROLE (Smart Account / Sub-DAO)
+            ├── REF_ROLE (Smart Account / Council)
             │
             ├── VER_ROLE (Individual Trusted Creator)
         */

contracts/core/interfaces/rights/IRightsAssetCustodian.sol

@@ -2,11 +2,18 @@
 // NatSpec format convention - https://docs.soliditylang.org/en/v0.5.10/natspec-format.html
 pragma solidity 0.8.26;
 
+import { IRightsAssetCustodianManager } from "@synaps3/core/interfaces/rights/IRightsAssetCustodianManager.sol";
 import { IRightsAssetCustodianVerifiable } from "@synaps3/core/interfaces/rights/IRightsAssetCustodianVerifiable.sol";
 import { IRightsAssetCustodianRegistrable } from "@synaps3/core/interfaces/rights/IRightsAssetCustodianRegistrable.sol";
 
 /// @title IRightsAssetCustodian
 /// @notice Unified interface for verifying, retrieving, and managing custodial rights over assets.
 /// @dev This interface extends both `IRightsAssetCustodianVerifiable` (which enables querying custodianship status)
 ///      and `IRightsAssetCustodianRegistrable` (which handles granting and revoking custodial rights).
-interface IRightsAssetCustodian is IRightsAssetCustodianVerifiable, IRightsAssetCustodianRegistrable {}
+interface IRightsAssetCustodian is
+    IRightsAssetCustodianManager,
+    IRightsAssetCustodianRegistrable,
+    IRightsAssetCustodianVerifiable
+{
+
+}

contracts/core/interfaces/rights/IRightsAssetCustodianRegistrable.sol

@@ -6,17 +6,12 @@ pragma solidity 0.8.26;
 /// @notice Interface for registering and managing custodial rights over assets.
 /// @dev This interface provides functions for granting and revoking custodial rights.
 interface IRightsAssetCustodianRegistrable {
+
     /// @notice Assigns custodial rights over the caller's content to a specified custodian.
     /// @param custodian The address of the custodian to assign.
     function grantCustody(address custodian) external;
 
     /// @notice Revokes custodial rights of a custodian for the caller's assets.
     /// @param custodian The address of the custodian to revoke custody from.
     function revokeCustody(address custodian) external;
-
-    /// @notice Sets a custom priority value for a specific custodian assigned to the caller.
-    /// @dev Influences the weighting in the balancing algorithm used to select custodians.
-    /// @param custodian The custodian whose priority is being set.
-    /// @param priority The priority value to assign. Must be >= 1.
-    function setPriority(address custodian, uint256 priority) external;
 }

contracts/core/interfaces/rights/IRightsAssetCustodianVerifiable.sol

@@ -25,7 +25,7 @@ interface IRightsAssetCustodianVerifiable {
     /// @param custodian The custodian address to query.
     /// @return The number of holders currently assigned to the custodian.
     function getCustodyCount(address custodian) external view returns (uint256);
-
+    
     /// @notice Calculates the weighted score of a custodian for a specific holder and currency.
     /// @dev Used to externally query the score that influences custodian selection.
     /// @param custodian The address of the custodian.

contracts/rights/RightsAssetCustodian.sol

@@ -117,6 +117,11 @@ contract RightsAssetCustodian is Initializable, UUPSUpgradeable, AccessControlle
         _maxRedundancy = value;
     }
 
+    /// @notice Returns the maximum allowed number of custodians per holder.
+    function getMaxAllowedRedundancy() external view returns (uint256) {
+        return _maxRedundancy;
+    }
+
     /// @notice Revokes custodial rights of a custodian for the caller's assets.
     /// @param custodian The custodian to revoke custody from.
     function revokeCustody(address custodian) external {

test/rights/RightAssetCustodian.t.sol

@@ -5,6 +5,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
+import { IRightsAssetCustodianManager } from "contracts/core/interfaces/rights/IRightsAssetCustodianManager.sol";
 import { IRightsAssetCustodianVerifiable } from "contracts/core/interfaces/rights/IRightsAssetCustodianVerifiable.sol";
 import { IRightsAssetCustodianRegistrable } from "contracts/core/interfaces/rights/IRightsAssetCustodianRegistrable.sol";
 import { ICustodianVerifiable } from "contracts/core/interfaces/custody/ICustodianVerifiable.sol";
@@ -24,6 +25,23 @@ contract RightAssetCustodianTest is CustodianShared {
         deployRightsAssetCustodian();
     }
 
+    function test_SetMaxAllowedRedundancy_ValidValue() public {
+        vm.startPrank(admin);
+        uint256 newMaxRedundancy = 5;
+        IRightsAssetCustodianManager(rightAssetCustodian).setMaxAllowedRedundancy(newMaxRedundancy);
+        uint256 maxRedundancy = IRightsAssetCustodianManager(rightAssetCustodian).getMaxAllowedRedundancy();
+        assertEq(maxRedundancy, newMaxRedundancy, "Max allowed redundancy should be updated");
+        vm.stopPrank();
+    }
+
+    function test_SetMaxAllowedRedundancy_RevertIf_NotAuthorized() public {
+        vm.startPrank(user);
+        uint256 newMaxRedundancy = 5;
+        vm.expectRevert(abi.encodeWithSignature("AccessManagedUnauthorized(address)", user));
+        IRightsAssetCustodianManager(rightAssetCustodian).setMaxAllowedRedundancy(newMaxRedundancy);
+        vm.stopPrank();
+    }
+
     function test_GrantCustody_ValidCustodian() public {
         vm.prank(user);
         IRightsAssetCustodianRegistrable(rightAssetCustodian).grantCustody(custodian);