todo: document improvements

Author: geolffreym

contracts/financial/AgreementManager.sol

@@ -185,6 +185,7 @@ contract AgreementManager is Initializable, UUPSUpgradeable, AccessControlledUpg
     /// @return The calculated fee amount based on the applicable fee scheme.
     function _calcFees(uint256 total, address target, address currency) private view returns (uint256) {
         // !IMPORTANT if fees manager does not support the currency or the target, will revert..
+        // TODO avoid revert, just check if the currency is supported and return 0
         (uint256 fees, T.Scheme scheme) = TOLLGATE.getFees(target, currency);
         if (scheme == T.Scheme.BPS) return total.perOf(fees); // bps calc
         if (scheme == T.Scheme.NOMINAL) return total.perOf(fees.calcBps()); // nominal to bps

contracts/financial/AgreementSettler.sol

@@ -166,13 +166,33 @@ contract AgreementSettler is
         return agreement;
     }
 
+    // modifier hookExec(address counterParty) {
+    //     // get registered exec hooks for this contract
+    //     // IHook hook = HOOKS.get(address(this), arbitrer, IExecHook) <- internal handling of any logic needed
+    //     // to get the valid hook
+
+    //     // if (hook) {
+    //     //     // execute the hook logic, eg: royalties, splits, etc..
+    //     //     // any error in the hook should revert the whole tx
+    //     //     hook.prev(abi.encode(msg.sender, counterParty, proof));
+    //     // }
+    //     _;
+    //     // if (hook) {
+    //     //     LEDGER_VAULT.approve(address(hook), available, currency);
+    //     //     // execute the hook logic, eg: royalties, splits, etc..
+    //     //     // any error in the hook should revert the whole tx
+    //     //     hook.post(abi.encode(msg.sender, counterParty, proof));
+    //     // }
+
+    // }
+
     /// @notice Settles an agreement by marking it inactive and transferring funds to the counterparty.
     /// @param proof The unique identifier of the agreement.
     /// @param counterparty The address that will receive the funds upon settlement.
     function settleAgreement(
         uint256 proof,
         address counterparty
-    ) public onlyValidAgreement(proof) returns (T.Agreement memory) {
+    ) public onlyValidAgreement(proof) /**hookExec(counterParty) */ returns (T.Agreement memory) {
         // retrieve the agreement to storage to inactivate it and return it
         T.Agreement memory agreement = AGREEMENT_MANAGER.getAgreement(proof);
         if (agreement.arbiter != msg.sender) revert UnauthorizedEscrowAgent();

contracts/rights/RightsPolicyManager.sol

@@ -75,6 +75,7 @@ contract RightsPolicyManager is
     /// @param holder The address of the rights holder who must have authorized the policy.
     /// @param policy The address of the policy contract attempting to access the rights.
     modifier onlyAuthorizedPolicy(address holder, address policy) {
+        require(policy != address(0), "Policy address cannot be zero");
         bool isPolicyAuthorizedByHolder = RIGHTS_AUTHORIZER.isPolicyAuthorized(policy, holder);
         if (!isPolicyAuthorizedByHolder) revert RightsNotDelegated(policy, holder);
         _;
@@ -192,6 +193,7 @@ contract RightsPolicyManager is
     /// @param account The address of the user whose compliance is being evaluated.
     /// @param policy The address of the policy contract to check compliance against.
     /// @param criteria Encoded data containing the parameters required to verify access.
+    /// @return `true` if the policy is registered and active for the account, otherwise `false`.
     function isActivePolicy(address account, address policy, bytes memory criteria) public view returns (bool) {
         if (!isRegisteredPolicy(account, policy)) return false;
         return _verifyPolicyAccess(account, policy, criteria);

package-lock.json

@@ -5,7 +5,7 @@
   "devDependencies": {
     "dotenv": "^16.4.5",
     "prettier-plugin-solidity": "^1.4.1",
-    "solhint": "^5.0.4",
+    "solhint": "^6.0.0",
     "solhint-plugin-prettier": "^0.1.0",
     "solidity-code-metrics": "^0.0.28"
   },