This repository was archived by the owner on Oct 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Swap out spray for Akka http #130
Comments
@CCheSumo does that error occur on every request or sporadically? Don't remember seeing it in my own testing. |
@seanpquig this error occurs on every single request. |
I'd suggest setting up a little python webserver, dumping the entire
request and looking for differences
…On Mon, Jul 10, 2017, 3:37 PM Chuck Che ***@***.***> wrote:
Reopened #130
<#130>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#130 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeFZ4gZ_hKiuX5DH6a9bjpvSFiglpeuks5sMqeugaJpZM4OSYbo>
.
|
@rcoh I compared the request with spray and akka-http, the only different is the generated the signature. Everything else is identical. Going to do a more thorough investigation when working on this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
Akka HTTP is the successor for spray. With the first non-experimental release of Akka HTTP, spray has reached its end-of-life. http://doc.akka.io/docs/akka-http/current/scala/http/migration-guide/migration-from-spray.html We would like to swap out spray for Akka HTTP. There was an initial effort here #111.
Although all the tests passed, there seems to be a bug in the PR that was not caught. As a result, a request with the change results in the following error
I spent half a day on it, all the changes seem legit and I was not able to figure out what was going wrong. A revert back to spray fix the problem. Since it is blocking our upgrade, I am going to keep the spray version and raise an issue to fix the bug and revert-revert changes in #111 here (cc @rcoh @seanpquig).
The text was updated successfully, but these errors were encountered: