Skip to content

Commit a474c3f

Browse files
committed
Support for ReSharper 2016.2
Fixes StyleCop/StyleCop#55
1 parent 2729559 commit a474c3f

File tree

6 files changed

+92
-85
lines changed

6 files changed

+92
-85
lines changed

install/StyleCop.nuspec

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
<metadata>
44
<id>StyleCop.StyleCop</id>
55
<title>StyleCop by JetBrains</title>
6-
<version>2016.1.4</version>
6+
<version>2016.2.0</version>
77
<authors>Matt Ellis, Andy Reeves</authors>
88
<owners>JetBrains, Matt Ellis</owners>
99
<summary>StyleCop analyzes C# source code to enforce a set of style and consistency rules. Maintained by JetBrains</summary>
1010
<description>StyleCop analyzes C# source code to enforce a set of style and consistency rules. This plugin is compatible with StyleCop 4.7.54, and maintained by JetBrains.</description>
1111
<releaseNotes>
12+
&#8226; Updated to ReSharper 2016.2 (StyleCop/StyleCop#55)
13+
14+
From 2016.1.4:
1215
&#8226; Create SuppressMessage attribute parameters more reliably
1316
&#8226; Works properly if StyleCop 4.7.49 is already loaded in Visual Studio
1417

@@ -43,7 +46,7 @@ From previous releases:
4346
<licenseUrl>https://github.com/StyleCop/StyleCop/blob/master/License.html</licenseUrl>
4447
<iconUrl>https://raw.githubusercontent.com/StyleCop/StyleCop/master/logo.png</iconUrl>
4548
<dependencies>
46-
<dependency id="Wave" version="[5.0]" />
49+
<dependency id="Wave" version="[6.0]" />
4750
</dependencies>
4851
<tags>StyleCop analysis</tags>
4952
</metadata>

src/StyleCop.ReSharper/BulbItems/Framework/V5BulbItemImpl.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ namespace StyleCop.ReSharper.BulbItems.Framework
3232
/// <summary>
3333
/// BulbItem Implementation for ReSharper build items.
3434
/// </summary>
35-
public abstract class V5BulbItemImpl : BulbItemImpl
35+
public abstract class V5BulbItemImpl : BulbActionBase
3636
{
3737
/// <summary>
3838
/// Gets or sets the description of the BulbItem.

src/StyleCop.ReSharper/CodeCleanup/Rules/LayoutRules.cs

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ namespace StyleCop.ReSharper.CodeCleanup.Rules
2525
using JetBrains.ReSharper.Psi.CodeStyle;
2626
using JetBrains.ReSharper.Psi.CSharp;
2727
using JetBrains.ReSharper.Psi.CSharp.CodeStyle;
28-
using JetBrains.ReSharper.Psi.CSharp.Impl.Tree;
2928
using JetBrains.ReSharper.Psi.CSharp.Parsing;
3029
using JetBrains.ReSharper.Psi.CSharp.Tree;
3130
using JetBrains.ReSharper.Psi.Impl.CodeStyle;
@@ -337,25 +336,21 @@ private static void ChainedStatementBlocksMustNotBePrecededByBlankLine(ITreeNode
337336
/// </param>
338337
private static void CommentsMustBePreceededByBlankLine(ITreeNode node)
339338
{
340-
ITreeNode siblingMinus2;
341-
ITreeNode siblingMinus1;
342-
ITreeNode siblingMinus3;
343-
344339
for (ITreeNode currentNode = node; currentNode != null; currentNode = currentNode.NextSibling)
345340
{
346341
if (currentNode is ICommentNode && !(currentNode is IDocCommentNode))
347342
{
348343
if (Utils.IsFirstNodeOnLine(currentNode) && !(currentNode.Parent is ICSharpFile))
349344
{
350-
siblingMinus1 = currentNode.PrevSibling;
345+
ITreeNode siblingMinus1 = currentNode.PrevSibling;
351346

352347
if (siblingMinus1 != null)
353348
{
354-
siblingMinus2 = siblingMinus1.PrevSibling;
349+
ITreeNode siblingMinus2 = siblingMinus1.PrevSibling;
355350

356351
if (siblingMinus2 != null)
357352
{
358-
siblingMinus3 = siblingMinus2.PrevSibling;
353+
ITreeNode siblingMinus3 = siblingMinus2.PrevSibling;
359354

360355
ITokenNode siblingMinus3Token = siblingMinus3 as ITokenNode;
361356
IWhitespaceNode siblingMinus2WhitespaceNode = siblingMinus2 as IWhitespaceNode;
@@ -368,7 +363,7 @@ private static void CommentsMustBePreceededByBlankLine(ITreeNode node)
368363
continue;
369364
}
370365

371-
if (siblingMinus3Token != null && siblingMinus3Token.GetTokenType() == TokenType.LBRACE)
366+
if (siblingMinus3Token != null && siblingMinus3Token.GetTokenType() == CSharpTokenType.LBRACE)
372367
{
373368
// if we're the start of a code block then don't insert a new line.
374369
continue;
@@ -380,8 +375,15 @@ private static void CommentsMustBePreceededByBlankLine(ITreeNode node)
380375
currentNode.InsertNewLineBefore();
381376

382377
////CSharpFormatterHelper.FormatterInstance.Format(currentNode.Parent);
383-
ICSharpCodeFormatter codeFormatter = (ICSharpCodeFormatter)CSharpLanguage.Instance.LanguageService().CodeFormatter;
384-
codeFormatter.Format(currentNode.Parent);
378+
LanguageService languageService = CSharpLanguage.Instance.LanguageService();
379+
if (languageService != null)
380+
{
381+
ICSharpCodeFormatter codeFormatter = (ICSharpCodeFormatter)languageService.CodeFormatter;
382+
if (codeFormatter != null)
383+
{
384+
codeFormatter.Format(currentNode.Parent);
385+
}
386+
}
385387
}
386388
}
387389
}

src/StyleCop.ReSharper/QuickFixes/Framework/ChangeStyleCopRuleAction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ namespace StyleCop.ReSharper.QuickFixes.Framework
2626
using JetBrains.ReSharper.Feature.Services.Bulbs;
2727
using JetBrains.ReSharper.Feature.Services.Daemon;
2828
using JetBrains.TextControl;
29-
using JetBrains.UI.CrossFramework;
29+
using JetBrains.UI.Application;
3030
using JetBrains.UI.Icons;
3131

3232
/// <summary>

0 commit comments

Comments
 (0)