Skip to content

Add i18n to JupyterLab #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
blairdrummond opened this issue Nov 2, 2020 · 9 comments · Fixed by #188
Closed
4 tasks done

Add i18n to JupyterLab #148

blairdrummond opened this issue Nov 2, 2020 · 9 comments · Fixed by #188
Assignees
Labels
area/ux Requires attention from UX: focus on user interaction or UI design component/jupyter good-first-issue Good for newcomers kind/feature priority/blocker size/XL 6+ days triage/blocked

Comments

@blairdrummond
Copy link
Contributor

blairdrummond commented Nov 2, 2020

Look into whether the JupyterLab UI can be offered in other languages.

  • i18n (including extensions) - finish FR language pack + use KF_LANG to set language on startup
  • Debugger - xpython
  • Extensions - use compatible versions
  • Docker Stacks - check for new release wih Jupyterlab 3.0. upstream issue: JupyterLab 3.0 jupyter/docker-stacks#1207
@brendangadd brendangadd transferred this issue from StatCan/aaw Nov 5, 2020
@brendangadd brendangadd changed the title Bilingual JupyterLab? Add i18n to JupyterLab Nov 5, 2020
@brendangadd brendangadd added area/ux Requires attention from UX: focus on user interaction or UI design component/jupyter good-first-issue Good for newcomers kind/feature priority/blocker size/S ~1 day labels Nov 5, 2020
@brendangadd brendangadd added size/L 4-5 days and removed size/S ~1 day labels Nov 5, 2020
@wg102 wg102 self-assigned this Nov 24, 2020
@wg102
Copy link
Contributor

wg102 commented Nov 30, 2020

The feature i18n and i10n (jupyterlab/jupyterlab#3965) is planned to be part of the 3.0 release (jupyterlab/jupyterlab#8038), which has no clear release date.
The i18n PR is rather extensive (jupyterlab/jupyterlab#8800).

The second part is having the translations (https://github.com/jupyterlab/language-packs), this is the issue for the Translations jupyterlab/jupyterlab#8829
which mentions the translations are done through crowdin. We will need those to be completed before we can use the language pack. https://crowdin.com/project/jupyterlab

I suggest to wait until this is merged and released before investigating if all our needs are met, and how to set the languages we want.

@JessicaBarh
Copy link
Contributor

JessicaBarh commented Jan 19, 2021

Extension supports JupyterLab 3 supports JupyterLab 3 + OL-compliant Details
@jupyterlab/server-proxy X X
@jupyterlab/toc X X prebuilt with JLab 3, no need to install
jupyterlab-git X X beta version, will be installing from this commit until new release
ipympl (jupyter-matplotlib) X X
jupyterlab-plotly X X
jupyterlab-execute-time X X
nbdime-jupyterlab X X beta version
jupyterlab-spellchecker X
jupyterlab-dash X X
jupyterlab-lsp X will be installing from this repo until it's merged upstream
jupyterlab spreadsheet X
kubeflow-kale-labextension
jupyterlab-variableinspector X
jupyter-archive X

@sylus
Copy link
Member

sylus commented Jan 21, 2021

@JessicaBarh it seems jupyterlab-theme-solarized-dark is supported on the 3.0.x line?

However I don't even think we use it anymore (not using solarized):

https://github.com/StatCan/kubeflow-containers/blob/master/resources/jupyterlab-overrides.json

@sylus
Copy link
Member

sylus commented Jan 21, 2021

@blairdrummond did we also add the french language pack for code-server (vscode)?

@blairdrummond
Copy link
Contributor Author

@Ito-Matsuda has been looking at that I think?

@Jose-Matsuda
Copy link
Contributor

I added it for kubeflow-containers-desktop yes. (Note that this PR incorrectly used the Microsoft marketplace version. I later made a PR to fix that by grabbing and building the extension from the French Language package git repo)

@blairdrummond
Copy link
Contributor Author

@Ito-Matsuda would you be able to take on that functionality for the kubeflow-containers? Should be the same process right?

@Jose-Matsuda
Copy link
Contributor

Yea adding it should be no problem.

@Jose-Matsuda
Copy link
Contributor

@blairdrummond this is just adding the language pack correct? I'm looking at how we installed the python and r extension and after testing adding the following
code-server --install-extension MS_CEINTL.vscode-language-pack-fr
get's the job done and the French language pack is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Requires attention from UX: focus on user interaction or UI design component/jupyter good-first-issue Good for newcomers kind/feature priority/blocker size/XL 6+ days triage/blocked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants