Skip to content

Conversation

@mo-radwan1
Copy link
Collaborator

Summary

This PR enhances enterprise documentation with clarifications for Teams integration and Agent Builder functionality.

Teams Integration Documentation:

  • Add multi-tenant vs single-tenant bot configuration section with clear YAML examples
  • Explain that multi-tenant is deprecated July 2025, single-tenant is recommended
  • Add troubleshooting for 'missing service principal in tenant' error
  • Include Bot Framework Portal and Teams Developer Portal reference links
  • Clarify Teams Gateway works with both Docker and Kubernetes deployments (not just Docker)

Agent Builder Documentation:

  • Add 'Downloading Agent Configurations' section explaining what downloaded YAML files are designed for
  • Clarify downloaded files are optimized for Agent Deployer (K8s/Helm), not local development
  • Explain differences between downloaded YAML and sam add agent generated files
  • Provide guidance on when to use Download vs Deploy buttons

Files Changed

  • docs/docs/documentation/developing/tutorials/teams-integration.md
  • docs/docs/documentation/enterprise/agent-builder.md

Test Plan

  • Review documentation rendering in local docs server
  • Verify all links are valid
  • Confirm YAML examples are correct and follow established patterns
  • Check that warning/info callouts render properly

…der download guidance

- Add multi-tenant vs single-tenant configuration section to Teams integration docs
- Clarify that multi-tenant is deprecated July 2025 and single-tenant is recommended
- Add Bot Framework Portal and Teams Developer Portal reference links
- Add troubleshooting for 'missing service principal' error
- Clarify Teams Gateway works with both Docker and Kubernetes deployments
- Add Download button section to Agent Builder docs explaining YAML files are designed for Agent Deployer
- Explain differences between downloaded YAML and sam add agent files
@mo-radwan1 mo-radwan1 changed the title docs: DATAGO-116733 add Teams bot tenant configuration and Agent Builder download guidance docs(DATAGO-116733): Add Teams bot tenant configuration and Agent Builder download guidance Nov 7, 2025
Copy link
Collaborator

@solace-mdupls solace-mdupls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @mo-radwan1 . A couple of improvements please.

2. Use multi-tenant by removing `microsoft_app_tenant_id` (temporary workaround)
3. Register service principal: `az ad sp create --id YOUR-APP-ID`

**Verify your configuration:** https://dev.botframework.com/bots
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could maybe be a step instead?


This error occurs when using single-tenant configuration (with `microsoft_app_tenant_id` set) but the app isn't properly registered in that tenant.

**Quick fixes:**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to "Solution". The quick fix implies there's another way to address this.

- Rename "Quick fixes" to "Solution" for clarity
- Convert configuration verification into a numbered step
@mo-radwan1 mo-radwan1 merged commit f15859e into main Nov 10, 2025
14 checks passed
@mo-radwan1 mo-radwan1 deleted the docs/datago-116733-teams-agent-builder-updates branch November 10, 2025 19:53
@sonarqube-solacecloud
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants