-
Notifications
You must be signed in to change notification settings - Fork 59
DATAGO-108136: Fix the extraction of CSV data from a JSON field #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issues with extracting CSV data from JSON fields and improves the robustness of artifact handling. The primary goal is to fix various problems that occur when LLMs attempt to extract text from JSON fields and convert that text to CSV format.
- Enhanced JSONPath processing to unwrap single-element arrays for more intuitive behavior
- Added intelligent CSV detection and parsing for embedded CSV content within JSON strings
- Updated artifact tool parameter handling to accept JSON strings instead of objects and improved version validation
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/solace_agent_mesh/common/utils/embeds/modifiers.py |
Adds single-element array unwrapping in JSONPath processing |
src/solace_agent_mesh/common/utils/embeds/converter.py |
Implements embedded CSV detection/parsing and enhanced serialization logic |
src/solace_agent_mesh/agent/tools/builtin_artifact_tools.py |
Changes metadata parameter from object to JSON string and adds version string validation |
src/solace_agent_mesh/agent/adk/callbacks.py |
Updates artifact block delimiters and documentation examples |
| Multiple test files | Updates expected outputs to reflect new single-element unwrapping behavior |
WhiteSource Policy Violation Summary❌ Following blocking Whitesource Policy Violations must be resolved in solaceai/solace-agent-mesh-pr-207
Follow this runbook to fix issues in your Whitesource project. |
gregmeldrum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good! Just 1 comment about csv validation.
|
|
||
| # Check that lines contain commas (basic CSV indicator) | ||
| for line in lines: | ||
| if "," not in line.strip(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can have csv without commas:
Name
Billy
Joe
|




Some things fixed: