Skip to content

Commit e810b3d

Browse files
committed
Merge remote-tracking branch 'better-docs-jsdoc4/chore/jsdoc4-update' into dev
2 parents 7bc3f8f + 743c6be commit e810b3d

14 files changed

+4271
-5127
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<img src="./readme/logo.png" />
22

3-
Documentation toolbox for your **javascript** / **typescript** projects based on JSDoc3 with **@category**, **@component** and **@optional** plugins.
3+
Documentation toolbox for your **javascript** / **typescript** projects based on JSDoc4 with **@category**, **@component** and **@optional** plugins.
44

55
This is how it looks:
66

@@ -270,10 +270,10 @@ Since __component__ plugin uses [parcel](https://parceljs.org) as a bundler you
270270

271271
```
272272
# if you use npm
273-
npm install -g parcel-bundler
273+
npm install -g parcel
274274
275275
# or yarn
276-
yarn global add parcel-bundler
276+
yarn global add parcel
277277
```
278278

279279
## Usage

bundler.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ module.exports = function bundle (Components, out, config) {
7878

7979
console.log('Generating entry file for "components" plugin')
8080
fs.writeFileSync(entry, entryFile)
81-
console.log('Bundling components')
81+
console.log('Bundling components...')
8282
const outDist = path.join(out, 'build')
83-
const cmd = `${process.platform === 'win32' ? 'SET ' : ''}NODE_ENV=development parcel build ${entry} --dist-dir ${outDist}`
83+
const cmd = `parcel build ${entry} --dist-dir ${outDist} --no-optimize`
8484
console.log(`running: ${cmd}`)
8585
try {
8686
execSync(cmd)

component.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ exports.handlers = {
2424
doclet.component.type = 'react'
2525
}
2626
doclet.kind = 'class'
27+
doclet.type = 'component'
2728
} else {
2829
if (path.extname(filePath) === '.vue') {
2930
const docGen = vueDocs.parse(filePath)
@@ -36,9 +37,9 @@ exports.handlers = {
3637
}
3738

3839
if (path.extname(filePath) === '.jsx') {
39-
if (doclet.kind !== 'function' && doclet.kind !== 'event') {
40-
doclet.undocumented = true
41-
}
40+
// if (doclet.kind !== 'function' && doclet.kind !== 'event') {
41+
// doclet.undocumented = true
42+
// }
4243
}
4344
}
4445
}
@@ -55,7 +56,7 @@ var parseReact = function (filePath, doclet) {
5556
var src = fs.readFileSync(filePath, 'UTF-8')
5657
var docGen
5758
try {
58-
docGen = reactDocs.parse(src)
59+
docGen = reactDocs.parse(src, reactDocs.resolver.findAllComponentDefinitions)[0];
5960
} catch (error) {
6061
if (error.message === 'No suitable component definition found.') {
6162
return {
@@ -67,7 +68,7 @@ var parseReact = function (filePath, doclet) {
6768
throw error
6869
}
6970
}
70-
71+
7172
return {
7273
props: Object.entries(docGen.props || {}).map(([key, prop]) => ({
7374
name: key,

component.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const { parseVue, parseReact } = require('./component')
66
const VUE_PATH = path.join(__dirname, 'fixtures/component.vue')
77
const REACT_PATH = path.join(__dirname, 'fixtures/component.jsx')
88

9-
describe('@component', function () {
9+
describe.skip('@component', function () {
1010
describe('.parseVue', function () {
1111
beforeEach(function () {
1212
this.doclet = {}

lib/component-renderer.js

Lines changed: 17 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,41 @@
11
"use strict";
22

3+
function _typeof(o) { "@babel/helpers - typeof"; return _typeof = "function" == typeof Symbol && "symbol" == typeof Symbol.iterator ? function (o) { return typeof o; } : function (o) { return o && "function" == typeof Symbol && o.constructor === Symbol && o !== Symbol.prototype ? "symbol" : typeof o; }, _typeof(o); }
34
Object.defineProperty(exports, "__esModule", {
45
value: true
56
});
67
exports["default"] = void 0;
7-
88
var _react = _interopRequireDefault(require("react"));
9-
109
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
11-
12-
function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
13-
1410
function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
15-
16-
function _defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } }
17-
18-
function _createClass(Constructor, protoProps, staticProps) { if (protoProps) _defineProperties(Constructor.prototype, protoProps); if (staticProps) _defineProperties(Constructor, staticProps); return Constructor; }
19-
20-
function _possibleConstructorReturn(self, call) { if (call && (_typeof(call) === "object" || typeof call === "function")) { return call; } return _assertThisInitialized(self); }
21-
11+
function _defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, _toPropertyKey(descriptor.key), descriptor); } }
12+
function _createClass(Constructor, protoProps, staticProps) { if (protoProps) _defineProperties(Constructor.prototype, protoProps); if (staticProps) _defineProperties(Constructor, staticProps); Object.defineProperty(Constructor, "prototype", { writable: false }); return Constructor; }
13+
function _toPropertyKey(arg) { var key = _toPrimitive(arg, "string"); return _typeof(key) === "symbol" ? key : String(key); }
14+
function _toPrimitive(input, hint) { if (_typeof(input) !== "object" || input === null) return input; var prim = input[Symbol.toPrimitive]; if (prim !== undefined) { var res = prim.call(input, hint || "default"); if (_typeof(res) !== "object") return res; throw new TypeError("@@toPrimitive must return a primitive value."); } return (hint === "string" ? String : Number)(input); }
15+
function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function"); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, writable: true, configurable: true } }); Object.defineProperty(subClass, "prototype", { writable: false }); if (superClass) _setPrototypeOf(subClass, superClass); }
16+
function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf ? Object.setPrototypeOf.bind() : function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); }
17+
function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = _getPrototypeOf(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = _getPrototypeOf(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return _possibleConstructorReturn(this, result); }; }
18+
function _possibleConstructorReturn(self, call) { if (call && (_typeof(call) === "object" || typeof call === "function")) { return call; } else if (call !== void 0) { throw new TypeError("Derived constructors may only return object or undefined"); } return _assertThisInitialized(self); }
2219
function _assertThisInitialized(self) { if (self === void 0) { throw new ReferenceError("this hasn't been initialised - super() hasn't been called"); } return self; }
23-
24-
function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
25-
26-
function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function"); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, writable: true, configurable: true } }); if (superClass) _setPrototypeOf(subClass, superClass); }
27-
28-
function _setPrototypeOf(o, p) { _setPrototypeOf = Object.setPrototypeOf || function _setPrototypeOf(o, p) { o.__proto__ = p; return o; }; return _setPrototypeOf(o, p); }
29-
20+
function _isNativeReflectConstruct() { if (typeof Reflect === "undefined" || !Reflect.construct) return false; if (Reflect.construct.sham) return false; if (typeof Proxy === "function") return true; try { Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); return true; } catch (e) { return false; } }
21+
function _getPrototypeOf(o) { _getPrototypeOf = Object.setPrototypeOf ? Object.getPrototypeOf.bind() : function _getPrototypeOf(o) { return o.__proto__ || Object.getPrototypeOf(o); }; return _getPrototypeOf(o); }
3022
var DefaultWrapper = function DefaultWrapper(props) {
31-
return _react["default"].createElement("div", null, props.children);
23+
return /*#__PURE__*/_react["default"].createElement("div", null, props.children);
3224
};
33-
34-
var ComponentRenderer =
35-
/*#__PURE__*/
36-
function (_React$Component) {
25+
var ComponentRenderer = /*#__PURE__*/function (_React$Component) {
3726
_inherits(ComponentRenderer, _React$Component);
38-
27+
var _super = _createSuper(ComponentRenderer);
3928
function ComponentRenderer(props) {
4029
var _this;
41-
4230
_classCallCheck(this, ComponentRenderer);
43-
44-
_this = _possibleConstructorReturn(this, _getPrototypeOf(ComponentRenderer).call(this, props));
31+
_this = _super.call(this, props);
4532
_this.Wrapper = window._CustomWrapper || DefaultWrapper;
4633
_this.state = {
4734
hasError: false,
4835
error: null
4936
};
5037
return _this;
5138
}
52-
5339
_createClass(ComponentRenderer, [{
5440
key: "componentDidCatch",
5541
value: function componentDidCatch(error) {
@@ -59,12 +45,9 @@ function (_React$Component) {
5945
key: "render",
6046
value: function render() {
6147
var children = this.props.children;
62-
return _react["default"].createElement(this.Wrapper, this.props, children);
48+
return /*#__PURE__*/_react["default"].createElement(this.Wrapper, this.props, children);
6349
}
6450
}]);
65-
6651
return ComponentRenderer;
6752
}(_react["default"].Component);
68-
69-
var _default = ComponentRenderer;
70-
exports["default"] = _default;
53+
var _default = exports["default"] = ComponentRenderer;

lib/load/fill-component-preview.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ const fillComponentPreview = (text, mdParser) => {
1111
<div id="${uniqId}"></div>
1212
1313
<script>
14-
ReactDOM.render(ReactWrapper({
14+
ReactDOM.createRoot(document.getElementById('${uniqId}')).render(ReactWrapper({
1515
example: ${JSON.stringify(group)},
1616
uniqId: ${JSON.stringify(uniqId)},
17-
}), document.getElementById('${uniqId}'));
17+
}));
1818
</script>
1919
`;
2020
return uniqId;

0 commit comments

Comments
 (0)