Added support for render tag completion for inline snippets #1068
+63
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
4 times, most recently
from
1cabd73 to
bcee95e
Compare
shoplando
force-pushed
the
introduce-doc-tag-inside-snippet-tag
branch
from
a47fc50 to
391578c
Compare
2 tasks
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
from
bcee95e to
692492c
Compare
shoplando
changed the base branch from
introduce-doc-tag-inside-snippet-tag
to
graphite-base/1068
shoplando
changed the base branch from
graphite-base/1068
to
add-doc-tag-snippet-support
This was referenced Oct 9, 2025
shoplando
changed the base branch from
add-doc-tag-snippet-support
to
graphite-base/1068
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
from
692492c to
3e5b8a1
Compare
shoplando
changed the base branch from
graphite-base/1068
to
add-doc-tag-snippet-support
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
from
3e5b8a1 to
599e439
Compare
shoplando
force-pushed
the
add-doc-tag-snippet-support
branch
2 times, most recently
from
2b6b68c to
984c187
Compare
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
from
599e439 to
1da6cbe
Compare
shoplando
force-pushed
the
add-doc-tag-snippet-support
branch
from
984c187 to
80f1e20
Compare
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
from
1da6cbe to
122e6f8
Compare
aswamy
approved these changes
Oct 14, 2025
...es/theme-language-server-common/src/completions/providers/RenderSnippetCompletionProvider.ts
Outdated
Show resolved
Hide resolved
...es/theme-language-server-common/src/completions/providers/RenderSnippetCompletionProvider.ts
Outdated
Show resolved
Hide resolved
...es/theme-language-server-common/src/completions/providers/RenderSnippetCompletionProvider.ts
Outdated
Show resolved
Hide resolved
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
2 times, most recently
from
1751d79 to
4467ee0
Compare
shoplando
force-pushed
the
add-doc-tag-snippet-support
branch
from
80f1e20 to
61e1110
Compare
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
2 times, most recently
from
5b21535 to
e008de5
Compare
shoplando
force-pushed
the
add-doc-tag-snippet-support
branch
from
61e1110 to
61afe9c
Compare
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
2 times, most recently
from
5f6220f to
cef145f
Compare
shoplando
force-pushed
the
add-doc-tag-snippet-support
branch
2 times, most recently
from
24dbcf0 to
6465a20
Compare
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
2 times, most recently
from
50eaabe to
aa24f09
Compare
shoplando
force-pushed
the
add-doc-tag-snippet-support
branch
from
6465a20 to
0263556
Compare
2 tasks
dejmedus
approved these changes
Oct 21, 2025
| } | ||
| } | ||
|
|
||
| function getInlineSnippetsNames(ast: LiquidHtmlNode): string[] { |
There was a problem hiding this comment.
Another scope/nesting question: do we want to limit the options to "current level" snippets? For example, should the below only offer header_inner?
example
There was a problem hiding this comment.
Oooh yeah you're right! Thanks for catching that 🙏
There was a problem hiding this comment.
Now I'm wondering if we should include it in other snippets? ie:
There was a problem hiding this comment.
Yeah this is tricky, hi-snip could be passed in via render to hi-snip-2, but should tooling expect that? Maybe we could just limit completion to prevent a snippet being offered inside itself and leave the rest as is?
@aswamy do you think that would make sense?
There was a problem hiding this comment.
Maybe we could just limit completion to prevent a snippet being offered inside itself and leave the rest as is?
I think you're right. For simplicity, we should only offer code completion to things that are explicitly defined within the snippet.
This includes ALL variables. The reason is that we aren't sure how the snippet is rendered, which can get very confusing.
shoplando
force-pushed
the
add-doc-tag-snippet-support
branch
from
0263556 to
9366de6
Compare
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
2 times, most recently
from
85ae0e5 to
ba844e6
Compare
shoplando
force-pushed
the
add-doc-tag-snippet-support
branch
from
9366de6 to
b4049b2
Compare
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
2 times, most recently
from
3886acb to
59eb787
Compare
shoplando
force-pushed
the
render-autocomplete-inline-snippet
branch
from
59eb787 to
791ddf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Solves #827
Added completion support for inline snippets in the render tag. Now when using the
{% render %}tag, the language server will suggest both file-based snippets and inline snippets defined within the same file. Inline snippets are displayed with a helpful documentation note indicating they are "defined in this file".What's next? Any followup issues?
changeset