Fix enabling scrobbling on and off to refresh bug (#45)

Author: stephanebruckert

CHANGELOG.md

@@ -1,9 +1,14 @@
 ## CHANGELOG
 
 ### Unrelaesed
-- Remove spaces from login
+
+#### Added
 - Send "Now playing" request to last.fm
 
+#### Fixed
+- Remove spaces from login
+- Fix bug where toggling "Enabled" on and off was needed to scrobble songs
+
 ### 1.3.0 (2021/11/23)
 
 - Scrobble with album name [issue #37](https://github.com/ShazamScrobbler/shazamscrobbler-macos/issues/37)

ShazamScrobbler/LastFmController.m

@@ -34,9 +34,14 @@ + (void)init {
     [LastFm sharedInstance].apiSecret = SECRET;
     [LastFm sharedInstance].session = [prefs valueForKey:@"session"];
     [LastFm sharedInstance].username = [prefs valueForKey:@"username"];
-    
+
+    // Initialize operation queue
     operationQueue = [[NSOperationQueue alloc] init];
     [operationQueue setMaxConcurrentOperationCount: 1];
+
+    // Ensure scrobbling state is properly initialized
+    MenuController *menu = ((AppDelegate *)[NSApplication sharedApplication].delegate).menu;
+    [menu.scrobblingItem setEnabled:([prefs stringForKey:@"session"] != nil)];
 }
 
 + (bool)login:(NSString*)username withPassword:(NSString*)password {

ShazamScrobbler/MenuController.m

@@ -205,13 +205,13 @@ - (IBAction)negateScrobbling:(id)sender
     NSInteger scrobbling = [[NSUserDefaults standardUserDefaults] integerForKey:@"scrobbling"];
     NSInteger state = scrobbling ? NSOffState : NSOnState;
     [[NSUserDefaults standardUserDefaults] setInteger:state forKey:@"scrobbling"];
-    
+    [[NSUserDefaults standardUserDefaults] synchronize]; // Ensure settings are saved
+
     [_scrobblingItem setState:state];
-    [_scrobblingItem setEnabled:state];
     [_main itemChanged:_scrobblingItem];
-    if (state == NSOnState) {
-        [ShazamController findNewTags];
-    }
+
+    // Always try to find new tags when toggling scrobbling
+    [ShazamController findNewTags];
 }
 
 - (void)updateScrobblingItemWith:(NSInteger)itemsToScrobble

ShazamScrobbler/ShazamController.m

@@ -126,7 +126,7 @@ + (void)watch:(NSString*) path {
 + (void)findNewTags  {
     //Initialize previous session information
     NSUserDefaults *prefs = [NSUserDefaults standardUserDefaults];
-    
+
     // Connection to the DB
     FMDatabase *database = [FMDatabase databaseWithPath:[ShazamConstants getSqlitePath]];