Adds trend work from SasData refactor #169
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| custom_test_directory = 'custom_test' | ||
|
|
||
| def get_files_to_load(directory_name: str) -> list[str]: |
There was a problem hiding this comment.
suggestion - this function is likely simpler using pathlib.Path rather than os.listdir/os.path.join; Path.iterdir will give the absolute path to the resource without needing to join the load_from back on again. (Pity that AsciiReaderParams doesn't accept Path objects)
| interpolated_trend = trend.interpolate(to_interpolate_on) | ||
| assert interpolated_trend.all_axis_match(to_interpolate_on) | ||
|
|
||
| def test_trend_q_axis_match(): |
There was a problem hiding this comment.
Is it possible for this test (or another test) to test that the maths is correct in the interpolation?
There was a problem hiding this comment.
Gates Failed
(1 file with Bumpy Road Ahead)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| trend.py | 1 critical rule | 9.24 | Suppress |
Quality Gate Profile: The Bare Minimum
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
No description provided.