[luci/pass] Revise Pass to fix gcc-13 error #15241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
seanshpark
force-pushed
the
luci_pass_virt
branch
from
d902930 to
b62fc6d
Compare
shs-park
previously approved these changes
Apr 28, 2025
Contributor
shs-park
left a comment
shs-park
left a comment
There was a problem hiding this comment.
I left some suggestions,
but the LGTM itself.
=)
This will revise luci::Pass to fix gcc-13 overloaded-virtual error. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
seanshpark
force-pushed
the
luci_pass_virt
branch
from
b62fc6d to
f0dad18
Compare
Contributor
Author
|
@jinevening , can you please also take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will revise luci::Pass to fix gcc-13 overloaded-virtual error.