Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Commit e036381

Browse files
authored
Merge pull request #1312 from bjones1/testing-fix
Improve CI
2 parents 595b589 + 3cbb3de commit e036381

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

.github/workflows/python-package.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,26 +28,22 @@ jobs:
2828
if: always()
2929

3030
- name: Setup npm and build runestone.js
31-
id: create-runestone-bundle
3231
run: |
3332
npm install
34-
npm run build
3533
- name: Set up Python ${{ matrix.python-version }}
36-
id: install-python
3734
uses: actions/setup-python@v2
3835
with:
3936
python-version: ${{ matrix.python-version }}
4037
- name: Install dependencies
41-
id: install-deps
4238
run: |
4339
python -m pip install --upgrade pip
4440
python -m pip install flake8 pytest
45-
pip install .
41+
# Install as editable so that tests run in cwd, instead of in wherever Python puts system lib. This is important because tests are run on the local (not system lib) files. Therefore, the npm run build produces its files locally, not in system libs; if installed in system libs, then the components won't be able to find these files.
42+
pip install -e .
4643
if [ -f requirements-dev.txt ]; then pip install -r requirements-dev.txt; fi
47-
- name: Test with pytest
48-
id: pytest
44+
- name: Tests
4945
run: |
50-
pytest
46+
pytest
5147
5248
- uses: act10ns/slack@v1
5349
with:

0 commit comments

Comments
 (0)