Merge pull request #10 from ReifyAB/jl/remove-no-validate-when-inlining-contraints

Remove skip validation setting when inlining constraint

Author: Jell

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## [Unreleased]
 
+- Remove no-op `NOT VALID` setting when inlining constraints
+
 ## [0.3.0] - 2025-03-15
 
 - Introduce StatementAppender for better spacing between statements

README.md

@@ -347,7 +347,9 @@ sequence indeed has default settings.
 
 ### InlineConstraints
 
-Inline non-foreign key constraints into table declaration
+Inline non-foreign key constraints into table declaration.
+
+Note that this also remove the `NOT VALID` setting if present, since that's a no-op when the constraint is created at the same time as the table.
 
 ### MoveIndicesAfterCreateTable
 

lib/activerecord-pg-format-db-structure/transforms/inline_constraints.rb

@@ -64,7 +64,7 @@ def match_alter_column_statement(raw_statement)
 
       def add_constraint!(raw_statement, constraint)
         raw_statement.stmt.create_stmt.table_elts << PgQuery::Node.from(
-          PgQuery::Constraint.new(constraint)
+          PgQuery::Constraint.new(constraint.merge(skip_validation: nil))
         )
       end
     end

spec/activerecord-pg-format-db-structure/transforms/inline_constraints_spec.rb

@@ -97,5 +97,34 @@
         ;
       SQL
     end
+
+    it "removes NO VALID when inlining since that's a no-op when inlined" do
+      formatter = ActiveRecordPgFormatDbStructure::Formatter.new(
+        transforms: [described_class]
+      )
+
+      source = +<<~SQL
+        CREATE TABLE public.posts (
+            id bigint NOT NULL,
+            score int NOT NULL,
+            created_at timestamp(6) without time zone NOT NULL,
+            updated_at timestamp(6) without time zone NOT NULL
+        );
+
+        ALTER TABLE ONLY public.posts ADD CONSTRAINT postive_score CHECK (score > 0) NOT VALID;
+      SQL
+
+      expect(formatter.format(source)).to eq(<<~SQL)
+        -- Name: posts; Type: TABLE;
+
+        CREATE TABLE public.posts (
+            id bigint NOT NULL,
+            score int NOT NULL,
+            created_at timestamp(6) NOT NULL,
+            updated_at timestamp(6) NOT NULL,
+            CONSTRAINT postive_score CHECK (score > 0)
+        );
+      SQL
+    end
   end
 end