Implement ClientException for 4xx responses in ResponseUtil

Author: Mohamed Khaled

src/Providers/Http/Exception/ClientException.php

@@ -0,0 +1,30 @@
+<?php
+
+declare(strict_types=1);
+
+namespace WordPress\AiClient\Providers\Http\Exception;
+
+/**
+ * Exception thrown for 4xx HTTP client errors.
+ *
+ * This represents errors where the client request was malformed,
+ * unauthorized, forbidden, or otherwise invalid.
+ *
+ * @since n.e.x.t
+ */
+class ClientException extends RequestException
+{
+    /**
+     * Creates a ClientException from a 400 Bad Request response.
+     *
+     * @since n.e.x.t
+     *
+     * @param string $errorDetail Details about what made the request bad.
+     * @return self
+     */
+    public static function fromBadRequestResponse(string $errorDetail = 'Invalid request parameters'): self
+    {
+        $message = sprintf('Bad request (400): %s', $errorDetail);
+        return new self($message);
+    }
+}

src/Providers/Http/HttpTransporter.php

@@ -16,8 +16,6 @@
 use WordPress\AiClient\Providers\Http\DTO\Request;
 use WordPress\AiClient\Providers\Http\DTO\Response;
 use WordPress\AiClient\Providers\Http\Exception\NetworkException;
-use WordPress\AiClient\Providers\Http\Exception\RequestException;
-
 /**
  * HTTP transporter implementation using HTTPlug.
  *
@@ -89,13 +87,6 @@ public function send(Request $request): Response
             );
         }
 
-        // Check for 400 Bad Request responses indicating invalid request data
-        if ($psr7Response->getStatusCode() === 400) {
-            $body = (string) $psr7Response->getBody();
-            $errorDetail = $body ? substr($body, 0, 200) : 'Invalid request parameters';
-            throw RequestException::fromBadRequest($psr7Request, $errorDetail);
-        }
-
         return $this->convertFromPsr7Response($psr7Response);
     }
 

src/Providers/Http/Util/ResponseUtil.php

@@ -5,6 +5,7 @@
 namespace WordPress\AiClient\Providers\Http\Util;
 
 use WordPress\AiClient\Providers\Http\DTO\Response;
+use WordPress\AiClient\Providers\Http\Exception\ClientException;
 use WordPress\AiClient\Providers\Http\Exception\ResponseException;
 
 /**
@@ -33,6 +34,13 @@ public static function throwIfNotSuccessful(Response $response): void
             return;
         }
 
+        // Check for 400 Bad Request responses indicating invalid request data
+        if ($response->getStatusCode() === 400) {
+            $body = (string) $response->getBody();
+            $errorDetail = $body ? substr($body, 0, 200) : 'Invalid request parameters';
+            throw ClientException::fromBadRequestResponse($errorDetail);
+        }
+
         throw ResponseException::fromBadResponse($response);
     }
 }