fix: solve visual bug in air place highlight

Author: coffeeispower

src/main/java/tools/redstone/redstonetools/features/toggleable/AirPlaceFeature.java

@@ -3,7 +3,6 @@
 import com.google.auto.service.AutoService;
 import net.fabricmc.fabric.api.client.rendering.v1.WorldRenderEvents;
 import net.minecraft.block.BlockState;
-import net.minecraft.block.Blocks;
 import net.minecraft.client.MinecraftClient;
 import net.minecraft.client.network.ClientPlayerEntity;
 import net.minecraft.client.render.Camera;
@@ -31,46 +30,13 @@
 @Feature(name = "Air Place", description = "Allows you to place blocks in the air.", command = "airplace")
 public class AirPlaceFeature extends ToggleableFeature {
 
-    public static boolean canAirPlace(PlayerEntity player) {
-        ItemStack itemStack = ItemUtils.getMainItem(player);
-
-        // empty slot
-        if (itemStack == null || itemStack.getItem() == Items.AIR)
-            return false;
-
-        // rocket boost for elytra
-        if (itemStack.getItem() == Items.FIREWORK_ROCKET &&
-                player.getEquippedStack(EquipmentSlot.CHEST).getItem() == Items.ELYTRA &&
-                player.isFallFlying())
-            return false;
-
-        return true;
-    }
-
-    public static HitResult findAirPlacePosition(MinecraftClient client) {
-        if (client.player == null)
-            return null;
-        ClientPlayerEntity player = client.player;
-
-        float reach = AirPlaceFeature.reach.getValue();
-        return player.raycast(reach, 0, false);
-    }
-
-    public static BlockHitResult findAirPlaceBlockHit(PlayerEntity playerEntity) {
-        var hit = RaycastUtils.rayCastFromEye(playerEntity, reach.getValue());
-        return new BlockHitResult(hit.getPos(), hit.getSide(), hit.getBlockPos(), false);
-    }
-
     public static final Argument<Float> reach = Argument
             .ofType(floatArg(3.0f))
             .withDefault(5.0f);
-
     public static final Argument<Boolean> showOutline = Argument
             .ofType(BoolSerializer.bool())
             .withDefault(true);
 
-    private static final BlockState FULL_BLOCK_STATE = Blocks.BEDROCK.getDefaultState();
-
     {
         // register ghost block renderer
         WorldRenderEvents.BEFORE_BLOCK_OUTLINE.register((context, blockOutlineContext) -> {
@@ -88,11 +54,10 @@ public static BlockHitResult findAirPlaceBlockHit(PlayerEntity playerEntity) {
             if (!canAirPlace(client.player))
                 return true;
 
-            HitResult hitResult = findAirPlacePosition(client);
+            BlockHitResult hitResult = findAirPlaceBlockHit(client.player);
             if (hitResult == null)
                 return true;
-            Vec3d pos = hitResult.getPos();
-            BlockPos blockPos = new BlockPos((int) pos.x, (int) pos.y, (int) pos.z);
+            BlockPos blockPos = hitResult.getBlockPos();
 
             BlockState blockState = ItemUtils.getUseState(client.player,
                     ItemUtils.getMainItem(client.player),
@@ -107,7 +72,7 @@ public static BlockHitResult findAirPlaceBlockHit(PlayerEntity playerEntity) {
             try {
                 VertexConsumer consumer = context.consumers().getBuffer(RenderLayer.getLines());
 
-                ((WorldRendererAccessor)context.worldRenderer()).invokeDrawBlockOutline(
+                ((WorldRendererAccessor) context.worldRenderer()).invokeDrawBlockOutline(
                         context.matrixStack(),
                         consumer,
                         client.player,
@@ -123,4 +88,30 @@ public static BlockHitResult findAirPlaceBlockHit(PlayerEntity playerEntity) {
         });
     }
 
+    public static boolean canAirPlace(PlayerEntity player) {
+        ItemStack itemStack = ItemUtils.getMainItem(player);
+
+        return
+                // empty slot
+                (itemStack != null && itemStack.getItem() != Items.AIR) &&
+                // rocket boost for elytra
+                (itemStack.getItem() != Items.FIREWORK_ROCKET ||
+                        player.getEquippedStack(EquipmentSlot.CHEST).getItem() != Items.ELYTRA ||
+                        !player.isFallFlying());
+    }
+
+    public static HitResult findAirPlacePosition(MinecraftClient client) {
+        if (client.player == null)
+            return null;
+        ClientPlayerEntity player = client.player;
+
+        float reach = AirPlaceFeature.reach.getValue();
+        return player.raycast(reach, 0, false);
+    }
+
+    public static BlockHitResult findAirPlaceBlockHit(PlayerEntity playerEntity) {
+        var hit = RaycastUtils.rayCastFromEye(playerEntity, reach.getValue());
+        return new BlockHitResult(hit.getPos(), hit.getSide(), hit.getBlockPos(), false);
+    }
+
 }