Skip to content

Commit fc52803

Browse files
committed
Reduced the unnecessary calls to calculateSymmetryNumber when calculating radical thermo.
calculateSymmetryNumber for saturated structure was called too frequently when calculating entropy of radical.
1 parent f5c3335 commit fc52803

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

rmgpy/data/thermo.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -814,16 +814,13 @@ def estimateRadicalThermoViaHBI(self, molecule, stableThermoEstimator ):
814814
saturatedStruct.updateLonePairs()
815815
saturatedStruct.multiplicity = 1
816816

817-
# Get thermo estimate for saturated form of structure
818-
thermoData = stableThermoEstimator(saturatedStruct)
817+
# Get thermo estimate for saturated form of structure
818+
thermoData = stableThermoEstimator(saturatedStruct)
819819
if thermoData is None:
820820
logging.info("Thermo data of saturated {0} of molecule {1} is None.".format(saturatedStruct, molecule))
821821
return None
822822
assert thermoData is not None, "Thermo data of saturated {0} of molecule {1} is None!".format(saturatedStruct, molecule)
823823

824-
# Undo symmetry number correction for saturated structure
825-
# saturatedStruct.calculateSymmetryNumber()
826-
# thermoData.S298.value_si += constants.R * math.log(saturatedStruct.symmetryNumber)
827824
# Correct entropy for symmetry number of radical structure
828825
molecule.calculateSymmetryNumber()
829826
thermoData.S298.value_si -= constants.R * math.log(molecule.symmetryNumber)

0 commit comments

Comments
 (0)