Upload script for releases and doc #2426
Merged
+570
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issue in promote_from_rc_to_final.py
Contributor
Author
example output upload from tarballs |
Contributor
Author
example output for dryrun (ignore the different versions. i was running the promotion script in between) |
ScottTodd
approved these changes
Dec 5, 2025
| python build_tools/packaging/upload_release_packages.py --input-dir ./promotion/download/ --no-upload-python --upload-tarballs --execute --use-release-buckets | ||
| ``` | ||
|
|
||
| ## 4. Update index files for the release bucket |
Member
There was a problem hiding this comment.
TODO: step 5 sanity check the uploaded files?
Comment on lines
+1
to
+3
| # How to make a release available | ||
|
|
||
| The steps for the release are: |
Member
There was a problem hiding this comment.
We may want a warning here saying these instructions are only for release team members 🤔
(permissions should be set up that way, but just to deter anyone casually browsing)
ScottTodd
approved these changes
Dec 5, 2025
Member
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
Fine to merge without addressing comments
Member
There was a problem hiding this comment.
We could also move this file to https://github.com/ROCm/TheRock/tree/main/docs/packaging
HereThereBeDragons
deleted the
users/lpromber/release_upload_script_and_doc
branch
Contributor
Author
|
comments can be addressed in a future pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script to upload releases (or any kind of .whls and .tar.gz) to some S3 bucket.
Expects directory structure to be the same as created by the download_prerelease_packages.py
Has 2 safety features:
Part of Issue #1891:
This is the third step of package promotion from release candidate (e.g.
7.10.0rc2) to release (7.10.0).