Skip to content

Commit 6a366de

Browse files
committed
Bug fix + tests adjustments.
1 parent 6b94692 commit 6a366de

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

lib/Request.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,11 @@ public static function formatRequestParameters($parameters_string) {
206206

207207
$params = array();
208208
foreach($parsed as $key => $param) {
209-
$params[] = $key."=".rawurlencode($param);
209+
if($param) {
210+
$params[] = $key . "=" . rawurlencode($param);
211+
} else {
212+
$params[] = $key;
213+
}
210214
}
211215

212216
return implode("&", $params);

tests/OpenIDConnectTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public function testAuthorize(): void
1111
RESO\RESO::setClientId($client_id);
1212
RESO\RESO::setClientSecret($client_secret);
1313
RESO\RESO::setAPIAuthUrl($api_auth_url);
14+
RESO\RESO::setAPITokenUrl($api_token_url);
1415
RESO\RESO::setAPIRequestUrl($api_request_url);
1516
$auth_code = RESO\OpenIDConnect::authorize($auth_username, $auth_password, $redirect_uri, $scope);
1617
$this->assertNotNull($auth_code);
@@ -22,6 +23,7 @@ public function testRequestAccessToken(): void
2223
RESO\RESO::setClientId($client_id);
2324
RESO\RESO::setClientSecret($client_secret);
2425
RESO\RESO::setAPIAuthUrl($api_auth_url);
26+
RESO\RESO::setAPITokenUrl($api_token_url);
2527
RESO\RESO::setAPIRequestUrl($api_request_url);
2628
$auth_code = RESO\OpenIDConnect::authorize($auth_username, $auth_password, $redirect_uri, $scope);
2729
$access_token = RESO\OpenIDConnect::requestAccessToken($auth_code, $redirect_uri, $scope);

tests/RequestTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public function testRequestMetadata(): void
1111
RESO\RESO::setClientId($client_id);
1212
RESO\RESO::setClientSecret($client_secret);
1313
RESO\RESO::setAPIAuthUrl($api_auth_url);
14+
RESO\RESO::setAPITokenUrl($api_token_url);
1415
RESO\RESO::setAPIRequestUrl($api_request_url);
1516
$auth_code = RESO\OpenIDConnect::authorize($auth_username, $auth_password, $redirect_uri, $scope);
1617
RESO\RESO::setAccessToken(RESO\OpenIDConnect::requestAccessToken($auth_code, $redirect_uri, $scope));
@@ -27,6 +28,7 @@ public function testRequest(): void
2728
RESO\RESO::setClientId($client_id);
2829
RESO\RESO::setClientSecret($client_secret);
2930
RESO\RESO::setAPIAuthUrl($api_auth_url);
31+
RESO\RESO::setAPITokenUrl($api_token_url);
3032
RESO\RESO::setAPIRequestUrl($api_request_url);
3133
$auth_code = RESO\OpenIDConnect::authorize($auth_username, $auth_password, $redirect_uri, $scope);
3234
RESO\RESO::setAccessToken(RESO\OpenIDConnect::requestAccessToken($auth_code, $redirect_uri, $scope));

tests/config.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
// API authentication URL
44
$api_auth_url = "";
55

6+
// API token URL
7+
$api_token_url = "";
8+
69
// API data request (web) URL
710
$api_request_url = "";
811

0 commit comments

Comments
 (0)