Make sure the plugin actually GCs

Author: Quenty

places/test_plugin_place.rbxl

@@ -19,6 +19,7 @@ function ConvertPane.new(gui, selectionService, terrainConverter)
 
 	self._canConvert = Instance.new("BoolValue")
 	self._canConvert.Value = false
+	self._maid:GiveTask(self._canConvert)
 
 	self._maid:GiveTask(self._canConvert.Changed:Connect(function()
 		self:_updateButton()
@@ -42,12 +43,6 @@ function ConvertPane.new(gui, selectionService, terrainConverter)
 	self:_updateStatus()
 	self:_updateButton()
 
-	-- self._maid:GiveTask(self._terrainConverter.OverwriteWater.Changed:Connect(function()
-	-- 	self:_updateStatus()
-	-- end))
-	-- self._maid:GiveTask(self._terrainConverter.OverwriteTerrain.Changed:Connect(function()
-	-- 	self:_updateStatus()
-	-- end))
 
 	return self
 end
@@ -70,10 +65,6 @@ function ConvertPane:_updateStatus()
 	local selection = self._selectionService:Get()
 
 	local canConvert
-	-- if not self._terrainConverter.OverwriteWater.Value and not self._terrainConverter.OverwriteTerrain.Value then
-	-- 	self._statusLabel.Text = "Can't overwrite water or terrain"
-	-- 	canConvert = false
-	-- else
 	if #selection == 0 then
 		self._statusLabel.Text = "Nothing selected"
 		canConvert = false

src/ConvertPane.lua

@@ -8,7 +8,7 @@ local Signal = require(script.Parent.Signal)
 local ConvertPane = require(script.Parent.ConvertPane)
 local Checkbox = require(script.Parent.Checkbox)
 
-local UI = {}
+local UI = setmetatable({}, BasicPane)
 UI.ClassName = "UI"
 UI.__index = UI
 
@@ -26,10 +26,10 @@ function UI.new(gui, selectonService, terrainConverter)
 	self._maid:GiveTask(self._materialList)
 
 	self._convertPane = ConvertPane.new(self.Gui.Content.ConvertPane, selectonService, terrainConverter)
+	self._maid:GiveTask(self._convertPane)
 	self._maid:GiveTask(self._convertPane.RequestConvert:Connect(function(selection)
 		self.RequestConvert:Fire(selection, self._materialList.SelectedMaterial.Value)
 	end))
-	self._maid:GiveTask(self._convertPane)
 
 	self.Gui.Header.CloseButton.MouseButton1Click:Connect(function()
 		self.RequestClose:Fire()

src/UI.lua

@@ -51,7 +51,6 @@ local function activate(button)
 	newScreenGui.Parent = IS_DEBUG_MODE and game.Players.LocalPlayer.PlayerGui or game.CoreGui
 
 	local ui = UI.new(newScreenGui.Main, selectionService, converter)
-
 	maid:GiveTask(ui)
 	maid:GiveTask(ui.RequestClose:Connect(function()
 		deactivate()