fix: mock players in studio local server dont have permissions to use cmdr #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quenty
reviewed
Nov 7, 2025
| assert(player, "Bad player") | ||
|
|
||
| -- when testing with mock players in studio, their userids are negative | ||
| if player.UserId < 0 then |
Owner
There was a problem hiding this comment.
we need to add a check for RunService:IsStudio() since guests are historically considered negative userIds in case Roblox ever does this again.
Contributor
Author
There was a problem hiding this comment.
I was under the impression that returned false in local servers but I was wrong (its just team tests). I'll add that in.
Contributor
Author
There was a problem hiding this comment.
Do you think we should just completely replace the negative userid checks with IsStudio checks?
Quenty
reviewed
Nov 7, 2025
|
|
||
| if permissionLevel == PermissionLevel.ADMIN or permissionLevel == PermissionLevel.CREATOR then | ||
| return Promise.resolved(player.UserId == self._userId or RunService:IsStudio()) | ||
| return Promise.resolved(player.UserId == self._userId or RunService:IsStudio() or player.UserId < 0) |
Owner
There was a problem hiding this comment.
same here, need a check if we're studio with the UserId check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a studio playtest with multiple players, their userids will be negative and
RunService:IsStudio()returns false. This fix handles those playtests correctly.