From bde17df0071ad6a26ebb5036b94faeee4af72ff9 Mon Sep 17 00:00:00 2001 From: Alex Turner Date: Fri, 3 Oct 2025 00:44:50 -0500 Subject: [PATCH 1/3] fix: Prevent playback on invalid targets --- src/animations/src/Shared/AnimationSlotPlayer.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/animations/src/Shared/AnimationSlotPlayer.lua b/src/animations/src/Shared/AnimationSlotPlayer.lua index 8ae63da944..ed5d98bb03 100644 --- a/src/animations/src/Shared/AnimationSlotPlayer.lua +++ b/src/animations/src/Shared/AnimationSlotPlayer.lua @@ -260,7 +260,7 @@ function AnimationSlotPlayer.Play( topMaid:GiveTask(self._animationTarget :ObserveBrio(function(target) - return target ~= nil + return target ~= nil and target.Parent ~= nil end) :Subscribe(function(brio) if brio:IsDead() then From 6ce7fc4503097f4a135754b53debf4fddeedb14a Mon Sep 17 00:00:00 2001 From: Alex Turner Date: Sun, 5 Oct 2025 14:22:15 -0500 Subject: [PATCH 2/3] fix: Correct localization warning condition --- .../src/Shared/Utils/LocalizationServiceUtils.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/clienttranslator/src/Shared/Utils/LocalizationServiceUtils.lua b/src/clienttranslator/src/Shared/Utils/LocalizationServiceUtils.lua index 00f60e0efa..6e2481bca8 100644 --- a/src/clienttranslator/src/Shared/Utils/LocalizationServiceUtils.lua +++ b/src/clienttranslator/src/Shared/Utils/LocalizationServiceUtils.lua @@ -64,7 +64,7 @@ function LocalizationServiceUtils.promisePlayerTranslator(player: Player) end) return promiseTranslator:Catch(function(err) - if err ~= ERROR_PUBLISH_REQUIRED and error ~= ERROR_TIMEOUT then + if err ~= ERROR_PUBLISH_REQUIRED and err ~= ERROR_TIMEOUT then warn(string.format("[LocalizationServiceUtils.promisePlayerTranslator] - %s", tostring(err))) end From 87b86118a3ceb489fc067754b4b1487f029895fd Mon Sep 17 00:00:00 2001 From: Alex Turner Date: Sun, 5 Oct 2025 15:44:49 -0500 Subject: [PATCH 3/3] Revert "fix: Correct localization warning condition" This reverts commit 6ce7fc4503097f4a135754b53debf4fddeedb14a. --- .../src/Shared/Utils/LocalizationServiceUtils.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/clienttranslator/src/Shared/Utils/LocalizationServiceUtils.lua b/src/clienttranslator/src/Shared/Utils/LocalizationServiceUtils.lua index 6e2481bca8..00f60e0efa 100644 --- a/src/clienttranslator/src/Shared/Utils/LocalizationServiceUtils.lua +++ b/src/clienttranslator/src/Shared/Utils/LocalizationServiceUtils.lua @@ -64,7 +64,7 @@ function LocalizationServiceUtils.promisePlayerTranslator(player: Player) end) return promiseTranslator:Catch(function(err) - if err ~= ERROR_PUBLISH_REQUIRED and err ~= ERROR_TIMEOUT then + if err ~= ERROR_PUBLISH_REQUIRED and error ~= ERROR_TIMEOUT then warn(string.format("[LocalizationServiceUtils.promisePlayerTranslator] - %s", tostring(err))) end