Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 5, 2025

Summary

A small bug fix to the unitary synthesis pass in the case that a non-default plugin in specified, and this plugin supports the basis gates but not the target. When target is specified, it should override both basis_gates and coupling_map, that is the plugin should be called with basis_gates and coupling_map coming from the target, and not from the standalone arguments. Previously the argument coupling_map was indeed taken from the target, but basis_gates were not.

Needed for #14952.


This is an automatic backport of pull request #15286 done by [Mergify](https://mergify.com).

(cherry picked from commit 52af478)
@mergify mergify bot requested a review from a team as a code owner November 5, 2025 10:42
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Nov 5, 2025
@github-actions github-actions bot added this to the 2.3.0 milestone Nov 5, 2025
@github-project-automation github-project-automation bot moved this to Ready in Qiskit 2.3 Nov 5, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19099329280

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 88.438%

Files with Coverage Reduction New Missed Lines %
crates/circuit/src/parameter/parameter_expression.rs 1 82.79%
crates/transpiler/src/passes/sabre/layout.rs 1 86.36%
crates/qasm2/src/lex.rs 4 91.75%
Totals Coverage Status
Change from base Build 18941246851: 0.05%
Covered Lines: 92411
Relevant Lines: 104492

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Nov 5, 2025
Merged via the queue into stable/2.2 with commit 703e176 Nov 5, 2025
29 checks passed
@jakelishman jakelishman deleted the mergify/bp/stable/2.2/pr-15286 branch November 5, 2025 17:43
@github-project-automation github-project-automation bot moved this from Ready to Done in Qiskit 2.3 Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: Bugfix Include in the "Fixed" section of the changelog

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants