Skip to content

Support arbitrary frame per second resampling for tracking dataloaders #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DriesDeprest opened this issue Jun 28, 2023 · 2 comments · May be fixed by #401
Open

Support arbitrary frame per second resampling for tracking dataloaders #200

DriesDeprest opened this issue Jun 28, 2023 · 2 comments · May be fixed by #401

Comments

@DriesDeprest
Copy link
Contributor

Context
Currently, we have a sample_rate argument in our different tracker data deserializers, which allows us to generate a TrackingDataset output with lower fps (= frames per second) than the original tracking data.

Proposal
Add a fps_output argument in tracking data deserializers, which can be an arbitrary number. Based on this argument and the fps of the raw tracking data file, we will construct a TrackingDataset output with the desired fps output. We will use sampling (to reduce the fps of the original file) or interpolation (to increase the fps of the original file), or a combination of both if required.

Goal
By introducing a fps_output argument in tracking data deserializers, users can more easily append/concatenate tracking data of different data sources together. This way, they don't need to worry about generating consistent frames per second between different providers themselves.

@JanVanHaaren
Copy link
Collaborator

I like the idea of adding support for resampling tracking datasets. However, following the Separation of Concerns principle, I'd expect this type of functionality in a transformer such as the DatasetTransformer rather than in a deserializer.

@koenvo
Copy link
Contributor

koenvo commented Jun 29, 2023

Agree.

Right now the deserializer accepts some arguments that are passed to the transformer. We might accept more arguments to pass it through.

@rmotmans rmotmans linked a pull request Jan 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants