Skip to content

Commit 531eb3a

Browse files
authored
Merge pull request #13 from PureMVC/develop
Develop
2 parents 145c150 + 84f145f commit 531eb3a

27 files changed

+6965
-135
lines changed

.github/workflows/node.js.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Node.js CI
22

33
on:
44
push:
5-
branches: [ "master", "develop" ]
5+
branches: [ "develop" ]
66
pull_request:
77
branches: [ "master" ]
88

@@ -13,7 +13,7 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
node-version: [19.x, 20.x, 21.x]
16+
node-version: [20.x, 21.x, 22.x]
1717

1818
steps:
1919
- uses: actions/checkout@v3
@@ -45,17 +45,15 @@ jobs:
4545
- run: npm install
4646
- run: npm run build
4747

48-
- name: Publish to npm dry-run
48+
- name: Authenticate with npm
4949
env:
50-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
51-
run: |
52-
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
53-
npm publish --dry-run
50+
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
51+
run: echo "//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}" > ~/.npmrc
52+
53+
- name: Run npm publish dry run
54+
run: npm run npm:publish:dry-run
5455

5556
- name: Publish to npm
56-
if: github.ref == 'refs/heads/master' && github.event_name == 'push'
5757
env:
5858
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
59-
run: |
60-
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
61-
npm publish
59+
run: npm run npm:publish

docs/Controller.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

docs/Facade.html

Lines changed: 6700 additions & 0 deletions
Large diffs are not rendered by default.

docs/MacroCommand.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

docs/Mediator.html

Lines changed: 14 additions & 4 deletions
Large diffs are not rendered by default.

docs/Model.html

Lines changed: 25 additions & 25 deletions
Large diffs are not rendered by default.

docs/Notification.html

Lines changed: 15 additions & 15 deletions
Large diffs are not rendered by default.

docs/Notifier.html

Lines changed: 67 additions & 3 deletions
Large diffs are not rendered by default.

docs/Observer.html

Lines changed: 44 additions & 5 deletions
Large diffs are not rendered by default.

docs/Proxy.html

Lines changed: 21 additions & 5 deletions
Large diffs are not rendered by default.

docs/SimpleCommand.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

docs/View.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

docs/core_Controller.js.html

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

docs/core_Model.js.html

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

docs/core_View.js.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

docs/index.html

Lines changed: 6 additions & 3 deletions
Large diffs are not rendered by default.

docs/patterns_command_MacroCommand.js.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

docs/patterns_command_SimpleCommand.js.html

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

docs/patterns_facade_Facade.js.html

Lines changed: 6 additions & 5 deletions
Large diffs are not rendered by default.

docs/patterns_mediator_Mediator.js.html

Lines changed: 6 additions & 6 deletions
Large diffs are not rendered by default.

docs/patterns_observer_Notification.js.html

Lines changed: 3 additions & 4 deletions
Large diffs are not rendered by default.

docs/patterns_observer_Notifier.js.html

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

docs/patterns_observer_Observer.js.html

Lines changed: 7 additions & 7 deletions
Large diffs are not rendered by default.

docs/patterns_proxy_Proxy.js.html

Lines changed: 7 additions & 7 deletions
Large diffs are not rendered by default.

package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"babel-plugin-add-module-exports": "^1.0.4",
7171
"babel-preset-env": "^0.0.0",
7272
"chai": "^4.2.0",
73-
"chromedriver": "^127.0.0",
73+
"chromedriver": "^130.0.2",
7474
"dotenv": "^16.0.3",
7575
"edgedriver": "^5.3.8",
7676
"geckodriver": "^4.2.1",

src/patterns/observer/Notifier.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class Notifier {
4747
constructor() {}
4848

4949
/**
50-
* Create and send an `Notification`.
50+
* Create and send a `Notification`.
5151
*
5252
* <P>Keeps us from having to construct new Notification
5353
* instances in our implementation code.</P>
@@ -86,7 +86,7 @@ class Notifier {
8686
/**
8787
* Return the Multiton Facade instance
8888
*
89-
* @typedef {Facade} Facade
89+
* @returns {Facade}
9090
*
9191
* @throws {Error}
9292
*/

0 commit comments

Comments
 (0)