Skip to content

Commit e59b740

Browse files
Tom BrouwsTom Brouws
Tom Brouws
authored and
Tom Brouws
committed
Merge pull request #107 from ProgrammingLife3/fix/removeUnusedHashableCollection
Removed HashableCollection
2 parents ae0d134 + 72c5735 commit e59b740

File tree

5 files changed

+12
-129
lines changed

5 files changed

+12
-129
lines changed

src/main/java/tudelft/ti2806/pl3/data/wrapper/util/HorizontalWrapUtil.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
import tudelft.ti2806.pl3.data.wrapper.VerticalWrapper;
88
import tudelft.ti2806.pl3.data.wrapper.WrappedGraphData;
99
import tudelft.ti2806.pl3.data.wrapper.Wrapper;
10-
import tudelft.ti2806.pl3.util.HashableCollection;
1110
import tudelft.ti2806.pl3.util.Pair;
1211

1312
import java.util.ArrayList;
1413
import java.util.HashMap;
14+
import java.util.HashSet;
1515
import java.util.List;
1616
import java.util.Map;
1717
import java.util.stream.Collectors;
@@ -160,7 +160,7 @@ static List<List<Wrapper>> findCombineableNodes(List<Wrapper> nodes) {
160160
List<Wrapper> foundGroup = new ArrayList<>();
161161
foundGroup.add(startNode);
162162

163-
HashableCollection<Genome> genome = new HashableCollection<>(startNode.getGenome());
163+
HashSet<Genome> genome = (HashSet<Genome>) startNode.getGenome();
164164
combineRight(startNode, foundGroup, genome);
165165
combineLeft(startNode, foundGroup, genome);
166166

@@ -187,12 +187,11 @@ static List<List<Wrapper>> findCombineableNodes(List<Wrapper> nodes) {
187187
* a set of genomes which should be equal for each found node
188188
*/
189189
private static void combineRight(Wrapper startNode, List<Wrapper> foundGroup,
190-
HashableCollection<Genome> genome) {
190+
HashSet<Genome> genome) {
191191
Wrapper node = startNode;
192192
while (node.getOutgoing().size() == 1
193193
&& node.getOutgoing().get(0).getIncoming().size() == 1
194-
&& genome.equals(new HashableCollection<>(node.getOutgoing()
195-
.get(0).getGenome()))) {
194+
&& genome.equals(node.getOutgoing().get(0).getGenome())) {
196195
node = node.getOutgoing().get(0);
197196
foundGroup.add(node);
198197
}
@@ -209,12 +208,11 @@ private static void combineRight(Wrapper startNode, List<Wrapper> foundGroup,
209208
* a set of genomes which should be equal for each found node
210209
*/
211210
private static void combineLeft(Wrapper startNode, List<Wrapper> foundGroup,
212-
HashableCollection<Genome> genome) {
211+
HashSet<Genome> genome) {
213212
Wrapper node = startNode;
214213
while (node.getIncoming().size() == 1
215214
&& node.getIncoming().get(0).getOutgoing().size() == 1
216-
&& genome.equals(new HashableCollection<>(node.getIncoming()
217-
.get(0).getGenome()))) {
215+
&& genome.equals(node.getIncoming().get(0).getGenome())) {
218216
node = node.getIncoming().get(0);
219217
foundGroup.add(0, node);
220218
}

src/main/java/tudelft/ti2806/pl3/data/wrapper/util/SpaceWrapUtil.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import tudelft.ti2806.pl3.data.wrapper.WrappedGraphData;
77
import tudelft.ti2806.pl3.data.wrapper.Wrapper;
88
import tudelft.ti2806.pl3.exception.DuplicateGenomeNameException;
9-
import tudelft.ti2806.pl3.util.HashableCollection;
109
import tudelft.ti2806.pl3.util.Pair;
1110

1211
import java.util.ArrayList;
@@ -195,7 +194,7 @@ private static List<Pair<Integer, Pair<Wrapper, Wrapper>>> computeAllCandidates(
195194
* @return a collection of buckets
196195
*/
197196
private static Collection<Pair<Set<Genome>, List<Wrapper>>> getNodesByGenome(List<Wrapper> nodes) {
198-
Map<HashableCollection<Genome>, Pair<Set<Genome>, List<Wrapper>>> searchMap = new HashMap<>();
197+
Map<Set<Genome>, Pair<Set<Genome>, List<Wrapper>>> searchMap = new HashMap<>();
199198
for (Wrapper node : nodes) {
200199
Set<Genome> genome = node.getGenome();
201200
/*
@@ -204,10 +203,10 @@ private static Collection<Pair<Set<Genome>, List<Wrapper>>> getNodesByGenome(Lis
204203
if (genome.size() <= 1) {
205204
continue;
206205
}
207-
Pair<Set<Genome>, List<Wrapper>> pair = searchMap.get(new HashableCollection<>(genome));
206+
Pair<Set<Genome>, List<Wrapper>> pair = searchMap.get(genome);
208207
if (pair == null) {
209208
pair = new Pair<>(genome, new ArrayList<>());
210-
searchMap.put(new HashableCollection<>(genome), pair);
209+
searchMap.put(genome, pair);
211210
}
212211
pair.getSecond().add(node);
213212
}

src/main/java/tudelft/ti2806/pl3/data/wrapper/util/VerticalWrapUtil.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import tudelft.ti2806.pl3.data.wrapper.VerticalWrapper;
66
import tudelft.ti2806.pl3.data.wrapper.WrappedGraphData;
77
import tudelft.ti2806.pl3.data.wrapper.Wrapper;
8-
import tudelft.ti2806.pl3.util.HashableCollection;
98
import tudelft.ti2806.pl3.util.Pair;
109

1110
import java.util.ArrayList;
@@ -95,15 +94,13 @@ private static List<CombineWrapper> generateCombinedNodes(List<Wrapper> nodes,
9594
* @return a list of edges which could be combined
9695
*/
9796
static List<List<Wrapper>> findCombineableNodes(List<Wrapper> nodes) {
98-
Map<Pair<HashableCollection<Wrapper>, HashableCollection<Wrapper>>,List<Wrapper>> map
97+
Map<Pair<List<Wrapper>, List<Wrapper>>,List<Wrapper>> map
9998
= new HashMap<>();
10099
for (Wrapper node : nodes) {
101-
List<Wrapper> list = map.get(new Pair<>(new HashableCollection<>(node.getIncoming()),
102-
new HashableCollection<>(node.getOutgoing())));
100+
List<Wrapper> list = map.get(new Pair<>(node.getIncoming(), node.getOutgoing()));
103101
if (list == null) {
104102
list = new ArrayList<>();
105-
map.put(new Pair<>(new HashableCollection<>(node.getIncoming()),
106-
new HashableCollection<>(node.getOutgoing())), list);
103+
map.put(new Pair<>(node.getIncoming(), node.getOutgoing()), list);
107104
}
108105
list.add(node);
109106
}

src/main/java/tudelft/ti2806/pl3/util/HashableCollection.java

Lines changed: 0 additions & 55 deletions
This file was deleted.

src/test/java/tudelft/ti2806/pl3/util/HashableCollectionTest.java

Lines changed: 0 additions & 56 deletions
This file was deleted.

0 commit comments

Comments
 (0)