Fix warnings.

Author: GillesTourreau

Directory.Build.props

@@ -41,6 +41,10 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+    </PackageReference>
   </ItemGroup>
 
   <!-- Add the default using directive for all the code -->

src/Communication.UI.Blazor/Calling/CallingService.cs

@@ -12,7 +12,7 @@ namespace PosInformatique.Azure.Communication.UI.Blazor
     /// Implementation of the <see cref="ICallingService"/> used to create instances
     /// of the <see cref="CallComposite"/>.
     /// </summary>
-    public class CallingService : ICallingService, IAsyncDisposable
+    public sealed class CallingService : ICallingService, IAsyncDisposable
     {
         private readonly IJSRuntime jsRuntime;
 

tests/.editorconfig

@@ -25,3 +25,9 @@ dotnet_diagnostic.BL0005.severity = none
 
 # CA1861: Avoid constant arrays as arguments
 dotnet_diagnostic.CA1861.severity = none
+
+# VSTHRD103: Call async methods when in an async method
+dotnet_diagnostic.VSTHRD103.severity = none
+
+# VSTHRD200: Use "Async" suffix for async methods
+dotnet_diagnostic.VSTHRD200.severity = none

tests/Communication.UI.Blazor.Demo/Pages/Home.razor.cs

@@ -11,6 +11,8 @@ namespace PosInformatique.Azure.Communication.UI.Blazor.Demo.Pages
 
     public partial class Home
     {
+        private readonly List<string> log;
+
         private CallAdapter? callAdapter;
 
         private string userId;
@@ -31,8 +33,6 @@ public partial class Home
 
         private bool leaveCallForEveryone;
 
-        private List<string> log;
-
         public Home()
         {
             this.userId = string.Empty;
@@ -49,7 +49,7 @@ public Home()
             this.raiseHandButton = true;
             this.screenShareButton = true;
 
-            this.log = new List<string>();
+            this.log = [];
         }
 
         public bool DisableLoad
@@ -78,6 +78,8 @@ public async ValueTask DisposeAsync()
 
                 this.callAdapter = null;
             }
+
+            GC.SuppressFinalize(this);
         }
 
         private async Task CreateUserAsync()