Skip to content

Commit f296995

Browse files
dependabot[bot]ijustiadmitrovsdobrovolschi
authored
build(deps): bump org.springframework.boot:spring-boot-dependencies from 3.3.5 to 3.4.0 (#2117)
* build(deps): bump org.springframework.boot:spring-boot-dependencies Bumps [org.springframework.boot:spring-boot-dependencies](https://github.com/spring-projects/spring-boot) from 3.3.5 to 3.4.0. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.5...v3.4.0) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-dependencies dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * spring-cloud-dependencies from 2023.0.4 to 2024.0.0 * Fix error message assert * build(deps): bump org.opensearch.client:spring-data-opensearch-starter from 1.5.4 to 1.6.0 * reorder modules * Update pom.xml * Resolve incompatibilities with Spring Boot 3.4.4 (#2373) * prevent overriding Cockroach's default port forwarding settings * remove the redundant testcontainers-bom dependency * enable Spring Booot's default CouchbaseAutoConfiguration * replace the @SpringBootConfiguration search with a nested @configuration class * update docs compatibility * remove redundant changes --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oleksandr <[email protected]> Co-authored-by: admitrov <[email protected]> Co-authored-by: Stanislav Dobrovolschi <[email protected]>
1 parent 51f32c5 commit f296995

File tree

18 files changed

+52
-165
lines changed

18 files changed

+52
-165
lines changed

README.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Usage of Spring Cloud in your production code is optional, but __you will need i
2222
|3.0.X, 3.1.X
2323
|3.0.X
2424

25-
|3.2.X
25+
|3.2.X, 3.3.X, 3.4.X
2626
|3.1.X
2727
|===
2828

embedded-cockroachdb/src/main/java/com/playtika/testcontainer/cockroach/CockroachDBProperties.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
@ConfigurationProperties("embedded.cockroach")
1111
public class CockroachDBProperties extends CommonContainerProperties {
1212
static final String BEAN_NAME_EMBEDDED_COCKROACHDB = "embeddedCockroachDb";
13-
14-
int port = 26257;
13+
static final int PORT = 26257;
1514

1615
String initScriptPath;
1716

embedded-cockroachdb/src/main/java/com/playtika/testcontainer/cockroach/EmbeddedCockroachDBBootstrapConfiguration.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,8 @@ public class EmbeddedCockroachDBBootstrapConfiguration {
3838
@ConditionalOnToxiProxyEnabled(module = "cockroach")
3939
ToxiproxyContainer.ContainerProxy cockroachContainerProxy(ToxiproxyContainer toxiproxyContainer,
4040
@Qualifier(BEAN_NAME_EMBEDDED_COCKROACHDB) CockroachContainer cockroachContainer,
41-
CockroachDBProperties properties,
4241
ConfigurableEnvironment environment) {
43-
ToxiproxyContainer.ContainerProxy proxy = toxiproxyContainer.getProxy(cockroachContainer, properties.getPort());
42+
ToxiproxyContainer.ContainerProxy proxy = toxiproxyContainer.getProxy(cockroachContainer, CockroachDBProperties.PORT);
4443

4544
Map<String, Object> map = new LinkedHashMap<>();
4645
map.put("embedded.cockroach.toxiproxy.host", proxy.getContainerIpAddress());
@@ -60,21 +59,19 @@ public CockroachContainer cockroach(ConfigurableEnvironment environment,
6059
Optional<Network> network) throws Exception {
6160

6261
CockroachContainer cockroachContainer = new CockroachContainer(ContainerUtils.getDockerImageName(properties))
63-
.withExposedPorts(properties.getPort())
6462
.withInitScript(properties.getInitScriptPath())
6563
.withNetworkAliases(COCKROACHDB_NETWORK_ALIAS);
6664

6765
network.ifPresent(cockroachContainer::withNetwork);
6866

6967
cockroachContainer = (CockroachContainer) configureCommonsAndStart(cockroachContainer, properties, log);
70-
registerCockroachDBEnvironment(cockroachContainer, environment, properties);
68+
registerCockroachDBEnvironment(cockroachContainer, environment);
7169
return cockroachContainer;
7270
}
7371

7472
private void registerCockroachDBEnvironment(CockroachContainer cockroach,
75-
ConfigurableEnvironment environment,
76-
CockroachDBProperties properties) {
77-
Integer mappedPort = cockroach.getMappedPort(properties.getPort());
73+
ConfigurableEnvironment environment) {
74+
Integer mappedPort = cockroach.getMappedPort(CockroachDBProperties.PORT);
7875
String host = cockroach.getHost();
7976

8077
LinkedHashMap<String, Object> map = new LinkedHashMap<>();
@@ -84,7 +81,7 @@ private void registerCockroachDBEnvironment(CockroachContainer cockroach,
8481
map.put("embedded.cockroach.user", cockroach.getUsername());
8582
map.put("embedded.cockroach.password", cockroach.getPassword());
8683
map.put("embedded.cockroach.networkAlias", COCKROACHDB_NETWORK_ALIAS);
87-
map.put("embedded.cockroach.internalPort", properties.getPort());
84+
map.put("embedded.cockroach.internalPort", CockroachDBProperties.PORT);
8885

8986
String jdbcURL = "jdbc:postgresql://{}:{}/{}";
9087
log.info("Started CockroachDB server. Connection details: {}, " +

embedded-couchbase/src/test/java/com/playtika/testcontainer/couchbase/EmbeddedCouchbaseBootstrapConfigurationTest.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
package com.playtika.testcontainer.couchbase;
22

3-
import com.playtika.testcontainer.couchbase.springdata.CouchbaseConfiguration;
43
import org.junit.jupiter.api.Test;
54
import org.springframework.beans.factory.annotation.Autowired;
5+
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
66
import org.springframework.boot.test.context.SpringBootTest;
7+
import org.springframework.context.annotation.Configuration;
78
import org.springframework.core.env.ConfigurableEnvironment;
89

910
import static org.assertj.core.api.Assertions.assertThat;
1011

1112
@SpringBootTest(
12-
classes = {CouchbaseConfiguration.class},
13+
classes = {EmbeddedCouchbaseBootstrapConfigurationTest.TestConfiguration.class},
1314
properties = {
1415
"spring.profiles.active=enabled",
15-
"spring.main.allow-bean-definition-overriding=true",
1616
"embedded.toxiproxy.proxies.couchbase.enabled=true"
1717
})
1818
public abstract class EmbeddedCouchbaseBootstrapConfigurationTest {
@@ -31,4 +31,9 @@ public void propertiesAreAvailable() {
3131
assertThat(System.getProperty("com.couchbase.bootstrapHttpDirectPort")).isNotEmpty();
3232
assertThat(System.getProperty("com.couchbase.bootstrapCarrierDirectPort")).isNotEmpty();
3333
}
34+
35+
@EnableAutoConfiguration
36+
@Configuration
37+
static class TestConfiguration {
38+
}
3439
}

embedded-couchbase/src/test/java/com/playtika/testcontainer/couchbase/springdata/CouchbaseConfiguration.java

Lines changed: 0 additions & 72 deletions
This file was deleted.

embedded-couchbase/src/test/java/com/playtika/testcontainer/couchbase/springdata/CouchbaseConfigurationProperties.java

Lines changed: 0 additions & 18 deletions
This file was deleted.

embedded-couchbase/src/test/java/com/playtika/testcontainer/couchbase/springdata/SpringDataTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ public class SpringDataTest extends EmbeddedCouchbaseBootstrapConfigurationTest
3737
@Autowired
3838
CouchbaseOperations couchbaseOperations;
3939

40-
@Autowired
41-
CouchbaseConfigurationProperties couchbaseConfigurationProperties;
42-
4340
@Test
4441
public void springDataShouldWork() {
4542
String key = "test::1";
Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
1-
couchbase.bucket=${embedded.couchbase.bucket}
2-
couchbase.user=${embedded.couchbase.user}
3-
couchbase.password=${embedded.couchbase.password}
4-
couchbase.bootstrapHttpDirectPort=${embedded.couchbase.toxiproxy.port}
5-
couchbase.bootstrapCarrierDirectPort=${embedded.couchbase.bootstrapCarrierDirectPort}
6-
couchbase.hosts=${embedded.couchbase.host}
7-
8-
9-
spring.couchbase.connection-string=couchbase://${embedded.couchbase.host}
1+
spring.couchbase.connection-string=couchbase://${embedded.couchbase.host}:${embedded.couchbase.bootstrapCarrierDirectPort}=kv,${embedded.couchbase.host}:${embedded.couchbase.toxiproxy.port}=manager
2+
spring.couchbase.username=${embedded.couchbase.user}
3+
spring.couchbase.password=${embedded.couchbase.password}
4+
spring.couchbase.env.timeouts.connect=20s
5+
spring.couchbase.env.timeouts.key-value=20s
106
spring.data.couchbase.bucket-name=${embedded.couchbase.bucket}
117
spring.data.couchbase.auto-index=true
12-
spring.couchbase.env.timeouts.connect=20000

embedded-influxdb/src/test/java/com/playtika/testcontainer/influxdb/EmbeddedInfluxDBBootstrapConfigurationTest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,17 @@
66
import org.junit.jupiter.api.Test;
77
import org.junit.jupiter.api.extension.ExtendWith;
88
import org.springframework.beans.factory.annotation.Autowired;
9+
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
910
import org.springframework.boot.test.context.SpringBootTest;
11+
import org.springframework.context.annotation.Configuration;
1012
import org.springframework.core.env.ConfigurableEnvironment;
1113
import org.springframework.test.context.junit.jupiter.SpringExtension;
1214

1315
import static io.restassured.RestAssured.given;
1416
import static org.assertj.core.api.Assertions.assertThat;
1517

1618
@ExtendWith(SpringExtension.class)
17-
@SpringBootTest(classes = {TestApplication.class})
19+
@SpringBootTest
1820
class EmbeddedInfluxDBBootstrapConfigurationTest {
1921

2022
@Autowired
@@ -47,4 +49,9 @@ void influxDatabaseIsAvailable() {
4749
private String getUrl() {
4850
return "http://" + influxDBProperties.getHost() + ":" + influxDBProperties.getPort();
4951
}
52+
53+
@EnableAutoConfiguration
54+
@Configuration
55+
static class TestConfiguration {
56+
}
5057
}

embedded-influxdb/src/test/java/com/playtika/testcontainer/influxdb/TestApplication.java

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)