Update CS (#43)

Author: kubawerlos

.php_cs.dist

@@ -11,54 +11,12 @@ EOF;
 
 return PhpCsFixer\Config::create()
     ->setRiskyAllowed(true)
-    ->setRules(array(
-        '@Symfony' => true,
-        '@Symfony:risky' => true,
-        'align_multiline_comment' => true,
-        'array_indentation' => true,
-        'array_syntax' => ['syntax' => 'short'],
-        'blank_line_before_statement' => true,
-        'combine_consecutive_issets' => true,
-        'combine_consecutive_unsets' => true,
-        'comment_to_phpdoc' => true,
-        'compact_nullable_typehint' => true,
-        'escape_implicit_backslashes' => true,
-        'explicit_indirect_variable' => true,
-        'explicit_string_variable' => true,
-        'final_internal_class' => true,
-        'fully_qualified_strict_types' => true,
-        'function_to_constant' => ['functions' => ['get_class', 'get_called_class', 'php_sapi_name', 'phpversion', 'pi']],
+    ->setRules([
+        '@PhpCsFixer' => true,
+        '@PhpCsFixer:risky' => true,
         'header_comment' => ['header' => $header],
-        'heredoc_to_nowdoc' => true,
-        'list_syntax' => ['syntax' => 'long'],
-        'logical_operators' => true,
-        'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline'],
-        'method_chaining_indentation' => true,
-        'multiline_comment_opening_closing' => true,
-        'no_alternative_syntax' => true,
-        'no_binary_string' => true,
-        'no_extra_blank_lines' => ['tokens' => ['break', 'continue', 'extra', 'return', 'throw', 'use', 'parenthesis_brace_block', 'square_brace_block', 'curly_brace_block']],
-        'no_null_property_initialization' => true,
-        'no_short_echo_tag' => true,
-        'no_superfluous_elseif' => true,
-        'no_unneeded_curly_braces' => true,
-        'no_unneeded_final_method' => true,
-        'no_unreachable_default_argument_value' => true,
-        'no_unset_on_property' => true,
-        'no_useless_else' => true,
-        'no_useless_return' => true,
-        'ordered_class_elements' => true,
-        'ordered_imports' => true,
-        'phpdoc_add_missing_param_annotation' => true,
-        'phpdoc_order' => true,
-        'phpdoc_trim_consecutive_blank_line_separation' => true,
-        'phpdoc_types_order' => true,
-        'return_assignment' => true,
-        'semicolon_after_instruction' => true,
-        'single_line_comment_style' => true,
-        'strict_comparison' => true,
-        'strict_param' => true,
-    ))
+        'php_unit_strict' => false,
+    ])
     ->setFinder(
         PhpCsFixer\Finder::create()
             ->in(__DIR__)

.travis.yml

@@ -23,7 +23,7 @@ env:
         - DEFAULT_COMPOSER_FLAGS="--no-interaction --no-progress"
 
 stages:
-    - Static Code Analysis
+    - Static code analysis
     - Test
 
 before_install:
@@ -66,8 +66,8 @@ script:
 jobs:
     include:
         -
-            stage: Static Code Analysis
-            php: 7.1
+            stage: Static code analysis
+            php: 7.3
             install:
                 - travis_retry composer update -d dev-tools $DEFAULT_COMPOSER_FLAGS
                 - composer info -d dev-tools -D | sort

dev-tools/composer.json

@@ -1,12 +1,12 @@
 {
     "require": {
-        "php": "^7.0"
+        "php": "^7.3"
     },
     "require-dev": {
-        "friendsofphp/php-cs-fixer": "^2.3",
+        "friendsofphp/php-cs-fixer": "^2.14",
         "localheinz/composer-normalize": "^1.1",
-        "mi-schi/phpmd-extension": "^4.2",
-        "phpmd/phpmd": "^2.4.3"
+        "mi-schi/phpmd-extension": "^4.3",
+        "phpmd/phpmd": "^2.6"
     },
     "conflict": {
         "hhvm": "*"

tests/AutoReviewTest.php

@@ -15,6 +15,8 @@
 
 /**
  * @coversNothing
+ *
+ * @internal
  */
 final class AutoReviewTest extends TestCase
 {

tests/ExpectOverSetExceptionTraitTest.php

@@ -17,6 +17,8 @@
 
 /**
  * @covers \PHPUnitGoodPractices\Traits\ExpectOverSetExceptionTrait
+ *
+ * @internal
  */
 final class ExpectOverSetExceptionTraitTest extends TestCase
 {
@@ -25,15 +27,15 @@ final class ExpectOverSetExceptionTraitTest extends TestCase
 
     public $violations = [];
 
-    public function setUp()
+    protected function setUp()
     {
         $this->violations = [];
         $self = $this;
         $customReporter = function ($issue) use ($self) { $self->violations[] = $issue; };
         Reporter::setCustomReporter($customReporter);
     }
 
-    public function tearDown()
+    protected function tearDown()
     {
         Reporter::clearCustomReporter();
     }

tests/ExpectationViaCodeOverAnnotationTraitTest.php

@@ -17,6 +17,8 @@
 
 /**
  * @covers \PHPUnitGoodPractices\Traits\ExpectationViaCodeOverAnnotationTrait
+ *
+ * @internal
  */
 final class ExpectationViaCodeOverAnnotationTraitTest extends TestCase
 {

tests/IdentityOverEqualityTraitTest.php

@@ -18,6 +18,8 @@
 
 /**
  * @covers \PHPUnitGoodPractices\Traits\IdentityOverEqualityTrait
+ *
+ * @internal
  */
 final class IdentityOverEqualityTraitTest extends TestCase
 {
@@ -26,7 +28,7 @@ final class IdentityOverEqualityTraitTest extends TestCase
     public $fixtureAttributeBool = true;
     public $fixtureAttributeInt = 123;
 
-    public function tearDown()
+    protected function tearDown()
     {
         Reporter::clearCustomReporter();
     }

tests/ProphecyOverMockObjectTraitTest.php

@@ -18,6 +18,8 @@
 
 /**
  * @covers \PHPUnitGoodPractices\Traits\ProphecyOverMockObjectTrait
+ *
+ * @internal
  */
 final class ProphecyOverMockObjectTraitTest extends TestCase
 {

tests/ProphesizeOnlyInterfaceTraitTest.php

@@ -22,6 +22,8 @@ interface FixtureInterface
 
 /**
  * @covers \PHPUnitGoodPractices\Traits\ProphesizeOnlyInterfaceTrait
+ *
+ * @internal
  */
 final class ProphesizeOnlyInterfaceTraitTest extends TestCase
 {

tests/ReporterTest.php

@@ -18,12 +18,14 @@
 
 /**
  * @covers \PHPUnitGoodPractices\Traits\Reporter
+ *
+ * @internal
  */
 final class ReporterTest extends TestCase
 {
     use IdentityOverEqualityTrait;
 
-    public function tearDown()
+    protected function tearDown()
     {
         // reset global `Reporter` state
         Reporter::useHeader(true);