rector: ReduceAlwaysFalseIfOrRector (#5039)

- https://getrector.com/rule-detail/reduce-always-false-if-or-rector

Author: sreichel

.phpstan.dist.baseline.neon

@@ -2622,18 +2622,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Core/Model/Encryption.php
 
-		-
-			rawMessage: Negated boolean expression is always false.
-			identifier: booleanNot.alwaysFalse
-			count: 2
-			path: app/code/core/Mage/Core/Model/File/Storage.php
-
-		-
-			rawMessage: Result of || is always false.
-			identifier: booleanOr.alwaysFalse
-			count: 1
-			path: app/code/core/Mage/Core/Model/File/Storage.php
-
 		-
 			rawMessage: 'Parameter #1 $params of method Mage_Core_Model_File_Storage_Database_Abstract::__construct() expects array, string|null given.'
 			identifier: argument.type

.rector.php

@@ -88,7 +88,6 @@
             DeadCode\ClassMethod\RemoveNullTagValueNodeRector::class, # todo: TMP
             DeadCode\ClassMethod\RemoveUnusedPrivateMethodParameterRector::class, # todo: TMP  (!?!)
             DeadCode\FunctionLike\RemoveDeadReturnRector::class, # todo: TMP
-            DeadCode\If_\ReduceAlwaysFalseIfOrRector::class, # todo: TMP
             DeadCode\If_\RemoveAlwaysTrueIfConditionRector::class, # todo: TMP
             DeadCode\If_\SimplifyIfElseWithSameContentRector::class, # todo: TMP
             DeadCode\Plus\RemoveDeadZeroAndOneOperationRector::class, # todo: TMP  (!?!)

app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column.php

@@ -221,7 +221,7 @@ protected function &_applyDecorators($value, $decorators)
             }
         }
 
-        if ((!is_array($decorators)) || empty($decorators)) {
+        if (empty($decorators)) {
             return $value;
         }
 

app/code/core/Mage/Core/Model/File/Storage.php

@@ -52,10 +52,6 @@ protected function _synchronizeHasErrors(
         Mage_Core_Model_Abstract $sourceModel,
         Mage_Core_Model_Abstract $destinationModel
     ) {
-        if (!$sourceModel || !$destinationModel) {
-            return true;
-        }
-
         return $sourceModel->hasErrors() || $destinationModel->hasErrors();
     }