Skip to content

Layer1 deploy #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Layer1 deploy #10

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b2586a
Added post-merge githook
VQTran123 Nov 28, 2022
2ea318c
Set envrionement variables inside mms5-layer1-service
VQTran123 Nov 29, 2022
ef54ca5
Added post-merge githook
VQTran123 Nov 29, 2022
89eecea
Update post-merge
VQTran123 Dec 6, 2022
21ea16d
.conf.example contents copied into .conf file
VQTran123 Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions docs/post-merge
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/usr/bin/env python3

import sys
import os.path

file_path = "mms5-layer1-service/src/main/resources/application.conf"
if os.path.exists(file_path):
# open both files
app_example = "mms5-layer1-service/src/main/resources/application.conf.example"
with open(file_path,'r') as firstfile, open(file_path,'w') as secondfile:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is meant to be opening the application.conf.example file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll edit the comment to reflect that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

application.conf.example should be copied to application.conf, not the other way around. Also, it should only write to the file if it does not exist. I'd suggest using 'x' file flag in the call to open with a try catch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the application.conf is a hidden file and actually does exist within that directory. The issue was that it was empty and so that would produce the original error. Because of this, the 'w' flag would be more appropriate as the 'x' flag will cause a "FileAlreadyExists" error. I have added the changes.

# read content from first file
for line in firstfile:
# append content to second file
secondfile.write(line)


2 changes: 1 addition & 1 deletion mms5-layer1-service
Open in desktop
Submodule mms5-layer1-service updated from d759e0 to efb997