Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Nov 10, 2025

Description

One Line Summary

  • adds more tests and clean up event manager typings

Details

  • add tests for event manager
  • improve typings for event manager by adding event listener map

Motivation

  • want to have more test coverage across all sdks

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george requested a review from a team as a code owner November 10, 2025 21:28
@fadi-george fadi-george force-pushed the fg/osnotification-tests branch from c9cfd74 to 9fdf699 Compare November 10, 2025 21:35
@fadi-george fadi-george force-pushed the fg/osnotification-tests branch from 9fdf699 to db39a4d Compare November 10, 2025 21:36
@fadi-george fadi-george merged commit d4e8c7c into main Nov 10, 2025
6 checks passed
@fadi-george fadi-george deleted the fg/osnotification-tests branch November 10, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants