Pas: Extends permission system #2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TYPE: Bugfix LINK: OGC-2512
- Add helper functions for parliamentarian/user creation - Add attendance creation helpers - Add commission setup helpers - Reduce test code duplication by ~26% (280→205 lines) - Fix line length violations in test files
- Add Private permission override for parliamentarian and
commission_president roles
- Fix attendance collection and individual attendance access permissions
- Parliamentarians can now view /attendence/{id} and /attendences routes
- Maintains security by only granting Private access for attendance models
- Add ownership-based access control for attendance records - Allow parliamentarians to access only their own attendance data - Allow commission presidents to access their own + members' data - Add file collection access permissions for parliamentarians - Add German translation for JSON schema validation message
- Move datetime import to module level in security.py - Remove unused GeneralFileCollection permission rule - Fix attendance view to properly filter records for parliamentarians - Ensure bulk edit grouping works with filtered results
1. Form Validation: Added validate_parliamentarian_id() method to AttendenceAddForm that:
- Ensures parliamentarians can only add attendance for themselves
- Allows commission presidents to add for their commission members
- Prevents unauthorized access attempts
2. Dropdown Restrictions: Modified on_request() method to:
- Show only the parliamentarian's own entry for regular parliamentarians
- Show self + commission members for commission presidents
- Show all parliamentarians for admins/editors (existing behavior)
cyrillkuettel
force-pushed
the
ogc-2573-berechtigungssystem-parlamentarier
branch
from
2d395bd to
13c7224
Compare
…ip user <-> parliamentarian
This reverts commit 8be0118.
cyrillkuettel
deleted the
ogc-2573-berechtigungssystem-parlamentarier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.
Commit message
Pas: Extends permission system
In some ways this is similar to 4f8e72c.
TYPE: Feature
LINK: OGC-2573
Checklist